Issue 7717017: Revert "Switch to using .pak files for locale data on Windows." (r97941)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7717017: Revert "Switch to using .pak files for locale data on Windows." (r97941) (Closed)

Created:
9 years, 4 months ago by mattm

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews, amit, pam+watch_chromium.org, jshin+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert "Switch to using .pak files for locale data on Windows." (r97941) Revert "Fix a bug where windows can't find the locale paks." (r97951) Revert "Fix the windows build." (r97954) TBR=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97968

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+955 lines, -213 lines)			Patch
M	build/all.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/app/locales/locales.gyp	View	1 chunk	+678 lines, -0 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/mini_installer/chrome.release	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/win/FILES	View	1 chunk	+49 lines, -49 lines	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	1 chunk	+49 lines, -49 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/l10n/l10n_util.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/base/resource/resource_bundle.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	ui/base/resource/resource_bundle.cc	View	4 chunks	+2 lines, -86 lines	0 comments	Download
M	ui/base/resource/resource_bundle_dummy.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/resource/resource_bundle_linux.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	ui/base/resource/resource_bundle_posix.cc	View	4 chunks	+68 lines, -1 line	0 comments	Download
M	ui/base/resource/resource_bundle_win.cc	View	4 chunks	+80 lines, -13 lines	0 comments	Download
M	views/views.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%283%29/builds/4498/steps/unit_tests/logs/stdio http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%283%29/builds/4498/steps/gfx_unittests/logs/stdio http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%283%29/builds/4498/steps/ui_tests/logs/stdio

9 years, 4 months ago (2011-08-24 01:35:19 UTC) #1

LGTM

Expand Messages | Collapse Messages