Issue 7717016: Revert 97955 - First pass on intents options UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7717016: Revert 97955 - First pass on intents options UI. (Closed)

Created:
9 years, 4 months ago by mattm

Modified:
9 years, 4 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 97955 - First pass on intents options UI. Copies the cookies view handler for intents. Add pass-throughs to grit for flag. Optionalize intents options page JS/CSS. Fix up data model to read title. Working test. R=jhawkins@chromium.org BUG=None TEST=*Intents* Review URL: http://codereview.chromium.org/7624012 TBR=gbillock@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97966

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1797 lines)			Patch
M	build/common.gypi	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	4 chunks	+3 lines, -28 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/intents/web_intents_registry_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View	1 chunk	+23 lines, -27 lines	0 comments	Download
M	chrome/browser/resources/options/content_settings.js	View	2 chunks	+3 lines, -9 lines	0 comments	Download
D	chrome/browser/resources/options/intents_list.js	View	1 chunk	+0 lines, -715 lines	0 comments	Download
D	chrome/browser/resources/options/intents_view.css	View	1 chunk	+0 lines, -181 lines	0 comments	Download
D	chrome/browser/resources/options/intents_view.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/browser/resources/options/intents_view.js	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/options.js	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/options_bundle.js	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	chrome/browser/ui/intents/intents_model.h	View	1 chunk	+0 lines, -133 lines	0 comments	Download
D	chrome/browser/ui/intents/intents_model.cc	View	1 chunk	+0 lines, -152 lines	0 comments	Download
D	chrome/browser/ui/intents/intents_model_unittest.cc	View	1 chunk	+0 lines, -185 lines	0 comments	Download
D	chrome/browser/ui/webui/options/intents_settings_handler.h	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	chrome/browser/ui/webui/options/intents_settings_handler.cc	View	1 chunk	+0 lines, -159 lines	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages