ntp4: default to 18 apps per page for new installs

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 83 matching lines @@
   // Sets the order that toolstrip URLs appear in the shelf.
   void SetShelfToolstripOrder(const URLList& urls);
 
   // Get the order that the browser actions appear in the toolbar.
   std::vector<std::string> GetToolbarOrder();
 
   // Set the order that the browser actions appear in the toolbar.
   void SetToolbarOrder(const std::vector<std::string>& extension_ids);
 
   // Called when an extension is installed, so that prefs get created.
+  // If |page_index| is -1, and the then a page will be found for the App.

[Mihai Parparita -not on Chrome, 2011/08/25 18:27:08]

Nit: "and the then" doesn't sound quite right and "App" probably shouldn't be
capitalized.

[Evan Stade, 2011/08/25 18:50:49]

you're right on both counts.

   void OnExtensionInstalled(const Extension* extension,
                             Extension::State initial_state,
                             bool from_webstore,
                             int page_index);
 
   // Called when an extension is uninstalled, so that prefs get cleaned up.
   void OnExtensionUninstalled(const std::string& extension_id,
                               const Extension::Location& location,
                               bool external_uninstall);
 
@@ skipping 156 matching lines @@
   // index a -1 value is returned.
   int GetAppLaunchIndex(const std::string& extension_id);
 
   // Sets a specific launch index for an extension with |extension_id|.
   void SetAppLaunchIndex(const std::string& extension_id, int index);
 
   // Gets the next available application launch index. This is 1 higher than the
   // highest current application launch index found for the page |on_page|.
   int GetNextAppLaunchIndex(int on_page);
 
+  // Gets the page a new app should install to. Starts on page 0, and if there
+  // are N or more apps on it, tries to install on the next page.
+  int GetNaturalAppPageIndex();
+
   // Sets the order the apps should be displayed in the app launcher.
   void SetAppLauncherOrder(const std::vector<std::string>& extension_ids);
 
   // Get the application page index for an extension with |extension_id|.  This
   // determines which page an app will appear on in page-based NTPs.  If
   // the app has no page specified, -1 is returned.
   int GetPageIndex(const std::string& extension_id);
 
   // Sets a specific page index for an extension with |extension_id|.
   void SetPageIndex(const std::string& extension_id, int index);
@@ skipping 191 matching lines @@
 
   scoped_refptr<ExtensionContentSettingsStore> content_settings_store_;
 
   // The URLs of all of the toolstrips.
   URLList shelf_order_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_