Add PNaCl TargetInfo to Clang

[nlewycky, 2011-08-23 21:22:26]

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp
File lib/Basic/Targets.cpp (right):

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2852: this->PointerWidth = this->PointerAlign = 32;
I don't think this is worth saving two lines :)

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2864: virtual void getArchDefines(const LangOptions &Opts,
Do you really want to leave this blank? __PNACL32__ or something?

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2865: MacroBuilder &Builder) const {
whitespace

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2892: unsigned &NumNames) const {
whitespace

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2898: unsigned &NumAliases) const {
whitespace

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2974: case llvm::Triple::le32:
Please add a blank line above.

[krasin, 2011-08-23 22:12:30]

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp
File lib/Basic/Targets.cpp (right):

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2852: this->PointerWidth = this->PointerAlign = 32;
On 2011/08/23 21:22:26, nlewycky wrote:
> I don't think this is worth saving two lines :)

Done.

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2864: virtual void getArchDefines(const LangOptions &Opts,
On 2011/08/23 21:22:26, nlewycky wrote:
> Do you really want to leave this blank? __PNACL32__ or something?

You're right. PNaCl gcc defines __pnacl__. Clang also should.

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2865: MacroBuilder &Builder) const {
On 2011/08/23 21:22:26, nlewycky wrote:
> whitespace

Done.

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2892: unsigned &NumNames) const {
On 2011/08/23 21:22:26, nlewycky wrote:
> whitespace

Done.

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2898: unsigned &NumAliases) const {
On 2011/08/23 21:22:26, nlewycky wrote:
> whitespace

Done.

http://codereview.chromium.org/7717004/diff/1001/lib/Basic/Targets.cpp#newcod...
lib/Basic/Targets.cpp:2974: case llvm::Triple::le32:
On 2011/08/23 21:22:26, nlewycky wrote:
> Please add a blank line above.

Done.

[nlewycky, 2011-08-24 01:32:49]

http://codereview.chromium.org/7717004/diff/7001/test/Driver/le32-unknown-nac...
File test/Driver/le32-unknown-nacl.cpp (right):

http://codereview.chromium.org/7717004/diff/7001/test/Driver/le32-unknown-nac...
test/Driver/le32-unknown-nacl.cpp:1: // RUN: %clang -ccc-host-triple
le32-unknown-nacl -ccc-echo %s -emit-llvm -c -o /tmp/OUTPUTNAME 2> %t.log
"/tmp/OUTPUTNAME"? Please use %t2 or something.

[krasin, 2011-08-24 01:56:10]

http://codereview.chromium.org/7717004/diff/7001/test/Driver/le32-unknown-nac...
File test/Driver/le32-unknown-nacl.cpp (right):

http://codereview.chromium.org/7717004/diff/7001/test/Driver/le32-unknown-nac...
test/Driver/le32-unknown-nacl.cpp:1: // RUN: %clang -ccc-host-triple
le32-unknown-nacl -ccc-echo %s -emit-llvm -c -o /tmp/OUTPUTNAME 2> %t.log
On 2011/08/24 01:32:49, nlewycky wrote:
> "/tmp/OUTPUTNAME"? Please use %t2 or something.

Done.

[jvoung - send to chromium..., 2011-08-24 18:04:11]

Question about getVAListDeclaration()

+cc pdox

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp
File lib/Basic/Targets.cpp (right):

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp#newco...
lib/Basic/Targets.cpp:2880: return "typedef void* __builtin_va_list;";
Should va_list be something more like what is documented here:

http://www.chromium.org/nativeclient/design-documents/native-client-applicati...

[jvoung - send to chromium..., 2011-08-24 18:05:41]

w/ actual cc...

[krasin, 2011-08-24 18:06:15]

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp
File lib/Basic/Targets.cpp (right):

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp#newco...
lib/Basic/Targets.cpp:2880: return "typedef void* __builtin_va_list;";
On 2011/08/24 18:04:11, jvoung wrote:
> Should va_list be something more like what is documented here:
I believe so. In fact, I have derived this particular method from some other
target. Thanks for pointing to the doc.

I will update CL soon.
> 
>
http://www.chromium.org/nativeclient/design-documents/native-client-applicati...

[krasin, 2011-08-24 19:33:17]

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp
File lib/Basic/Targets.cpp (right):

http://codereview.chromium.org/7717004/diff/11002/lib/Basic/Targets.cpp#newco...
lib/Basic/Targets.cpp:2880: return "typedef void* __builtin_va_list;";
On 2011/08/24 18:06:15, krasin wrote:
> On 2011/08/24 18:04:11, jvoung wrote:
> > Should va_list be something more like what is documented here:
> I believe so. In fact, I have derived this particular method from some other
> target. Thanks for pointing to the doc.
> 
> I will update CL soon.
> > 
> >
>
http://www.chromium.org/nativeclient/design-documents/native-client-applicati...
> 

Done.

[jvoung - send to chromium..., 2011-08-24 20:16:39]

LGTM