Issue 7715037: Web Intent Picker UI (implemented as a constrained dialog, linux only)

Issue 7715037: Web Intent Picker UI (implemented as a constrained dialog, linux only) (Closed)

Created:
9 years, 4 months ago by binji

Modified:
9 years, 3 months ago

Reviewers:
pink (ping after 24hrs), sky, Evan Stade

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Web Intent Picker UI (implemented as a constrained dialog, linux only) BUG=none TEST=WebIntentControllerPickerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98888

Patch Set 1 #

Patch Set 2 : linux_views/chromeos fix #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1088 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/web_intent_picker_gtk.h	View		1 chunk	+76 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/web_intent_picker_gtk.cc	View		1 chunk	+142 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_constrained_dialog_factory.h	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_constrained_dialog_factory.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker.h	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker_controller.h	View		1 chunk	+97 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		1 chunk	+264 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc	View		1 chunk	+273 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker_delegate.h	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/intents/web_intent_picker_factory.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View		3 chunks	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/web_intent_picker_view.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

binji

My last commit was reverted. Patchset 1 is the old version. Patchset 2 is the ...

9 years, 4 months ago (2011-08-24 23:23:07 UTC) #1

Evan Stade

9 years, 3 months ago (2011-08-29 19:27:42 UTC) #5

I don't think you need LGT.Ms from all owners given that you're only making a
one line change versus your last patch. But I would put something like

retry rXXXXX, which was reverted for breaking such and such. Previous review:
<link>

also, you should probably run this by the trybots if you haven't already (I
don't see any try results for ps2)

Expand Messages | Collapse Messages