Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 7715033: [cros] Fix issue with focus stealing when choosing user picture with left/right arrows. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Oobe user image screen implementation. 6 * @fileoverview Oobe user image screen implementation.
7 */ 7 */
8 8
9 cr.define('oobe', function() { 9 cr.define('oobe', function() {
10 /** 10 /**
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 userImageList.addEventListener('keydown', function(e) { 125 userImageList.addEventListener('keydown', function(e) {
126 var prevIndex = userImageScreen.selectedUserImage_; 126 var prevIndex = userImageScreen.selectedUserImage_;
127 var len = userImageList.children.length; 127 var len = userImageList.children.length;
128 if (e.keyCode == 39 || e.keyCode == 40) { // right or down 128 if (e.keyCode == 39 || e.keyCode == 40) { // right or down
129 if (prevIndex < len - 1) 129 if (prevIndex < len - 1)
130 UserImageScreen.selectUserImage(prevIndex + 1); 130 UserImageScreen.selectUserImage(prevIndex + 1);
131 } else if (e.keyCode == 37 || e.keyCode == 38) { // left or up 131 } else if (e.keyCode == 37 || e.keyCode == 38) { // left or up
132 if (prevIndex > 0) 132 if (prevIndex > 0)
133 UserImageScreen.selectUserImage(prevIndex - 1); 133 UserImageScreen.selectUserImage(prevIndex - 1);
134 } 134 }
135 e.stopPropagation();
135 }); 136 });
136 }; 137 };
137 138
138 /** 139 /**
139 * Selects the specified user image and shows it in preview. 140 * Selects the specified user image and shows it in preview.
140 * @param {number} index The index of the image to select. 141 * @param {number} index The index of the image to select.
141 */ 142 */
142 UserImageScreen.selectUserImage = function(index) { 143 UserImageScreen.selectUserImage = function(index) {
143 var userImageList = $('user-image-list'); 144 var userImageList = $('user-image-list');
144 var userImageScreen = $('user-image'); 145 var userImageScreen = $('user-image');
145 var prevIndex = userImageScreen.selectedUserImage_; 146 var prevIndex = userImageScreen.selectedUserImage_;
146 if (prevIndex != -1) { 147 if (prevIndex != -1) {
147 userImageList.children[prevIndex].classList.remove('user-image-selected'); 148 userImageList.children[prevIndex].classList.remove('user-image-selected');
148 userImageList.children[prevIndex].setAttribute('tabIndex', '-1'); 149 userImageList.children[prevIndex].setAttribute('tabIndex', '-1');
149 } 150 }
150 if (index != -1) { 151 if (index != -1) {
151 var selectedImage = userImageList.children[index]; 152 var selectedImage = userImageList.children[index];
152 selectedImage.classList.add('user-image-selected'); 153 selectedImage.classList.add('user-image-selected');
153 selectedImage.setAttribute('tabIndex', '0'); 154 selectedImage.setAttribute('tabIndex', '0');
154 selectedImage.focus(); 155 selectedImage.focus();
155 $('user-image-preview').src = selectedImage.src; 156 $('user-image-preview').src = selectedImage.src;
156 } 157 }
157 userImageScreen.selectedUserImage_ = index; 158 userImageScreen.selectedUserImage_ = index;
158 }; 159 };
159 160
160 return { 161 return {
161 UserImageScreen: UserImageScreen 162 UserImageScreen: UserImageScreen
162 }; 163 };
163 }); 164 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698