Issue 7715032: gtk: Change BrowserList::GetLastActive() to GetLastActiveWithProfile() in page_info_bubble_gtk.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7715032: gtk: Change BrowserList::GetLastActive() to GetLastActiveWithProfile() in page_info_bubble_gtk.cc. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Elliot Glaysher, Miranda Callahan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

gtk: Change BrowserList::GetLastActive() to GetLastActiveWithProfile() in page_info_bubble_gtk.cc. BUG=86361 TEST=None R=mirandac@chromium.org,erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98291

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/gtk/page_info_bubble_gtk.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Miranda Callahan

On 2011/08/25 00:29:04, tfarina wrote: > +erg for review! LGTM, but wait for erg to ...

9 years, 4 months ago (2011-08-25 08:36:11 UTC) #3

Miranda Callahan

On 2011/08/25 08:36:11, Miranda Callahan wrote: > On 2011/08/25 00:29:04, tfarina wrote: > > +erg ...

9 years, 4 months ago (2011-08-25 08:36:35 UTC) #4

lgtm