Debouncing of function rescanning directory in File Manager

chrome/browser/resources/file_manager/js/file_manager.js

Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index df62d006c528dced0c043397c5f44a59a693f3f0..85ac767d2eba1db5b9b683f993ad27afdf1a2e84 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -1795,7 +1795,7 @@ FileManager.prototype = {
       if (event.status == 'success' ||
           event.status == 'error_unknown_filesystem' ||
           event.status == 'error_unsuported_filesystem')
-        self.rescanDirectory_();
+        self.rescanDirectory_(null, 300);
     });
   };
 
@@ -2523,12 +2523,61 @@ FileManager.prototype = {
   };
 
   /**
-   * Rescan the current directory, refreshing the list.
+   * Rescans the current directory, refreshing the list. It decreases the
+   * probability that two such calls are pending simultaneously.
    *
    * @param {function()} opt_callback Optional function to invoke when the
    *     rescan is complete.
+   * @param {string} delayMS Delay during which next rescanDirectory calls
+   *     can happen.
    */
-  FileManager.prototype.rescanDirectory_ = function(opt_callback) {
+
+  FileManager.prototype.rescanDirectory_ = function(opt_callback, delayMS) {
+    var self = this;
+    function done(count) {
+      // Variable count is introduced because we only want to do callbacks, that
+      // were in the queue at the moment of rescanDirectoryNow invocation.
+      while (count--) {
+        var callback = self.rescanDirectory_.callbacks.shift();
+        callback();
+      }
+    }
+
+    // callbacks is a queue of callbacks that need to be called after rescaning
+    // directory is done. We push callback to the end and pop form the front.
+    // When we get to actually call rescanDirectoryNow_ we need to remember how
+    // many callbacks were in a queue at the time, not to call callbacks that
+    // arrived in the middle of execution (they may depend on rescaning being
+    // done after they called rescanDirectory_).
+    if (!this.rescanDirectory_.callbacks)
+      this.rescanDirectory_.callbacks = [];
+
+    if (opt_callback)
+      this.rescanDirectory_.callbacks.push(opt_callback);
+
+    delayMS = delayMS || 100;
+
+    // Assumes rescanDirectoryNow_ takes less than 100 ms. If not there is
+    // a possible overlap between two calls.
+    if (delayMS < 100)
+      delayMS = 100;
+
+    if (this.rescanDirectory_.handle)
+      clearTimeout(this.rescanDirectory_.handle);
+    this.rescanDirectory_.handle = setTimeout(function () {
+        self.rescanDirectoryNow_(done.bind(null,

[rginda, 2011/08/25 19:14:56]

This is usually done with another nested function, rather than a bind call.

[sidor, 2011/08/25 23:54:17]

Done.

+            self.rescanDirectory_.callbacks.length));
+      }, delayMS);
+  };
+
+  /**
+   * Rescans the current directory immediately, refreshing the list. Should NOT
+   * be used in most cases. Instead use rescanDirectory_.
+   *
+   * @param {function()} opt_callback Optional function to invoke when the
+   *     rescan is complete.
+   */
+  FileManager.prototype.rescanDirectoryNow_ = function(opt_callback) {
     var self = this;
     var reader;