Issue 7715022: Print Preview: Provide a link to try printing with the system dialog when print preview fails. Al...

Issue 7715022: Print Preview: Provide a link to try printing with the system dialog when print preview fails. Al... (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, kmadhusu

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Print Preview: Provide a link to try printing with the system dialog when print preview fails. Also fix an initiator tab closed case that is being misreported as a failure. BUG=92599 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98400

Patch Set 1 #

Total comments: 2

Patch Set 2 : update string message #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View	1	3 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

http://codereview.chromium.org/7715022/diff/1/chrome/browser/resources/print_preview/print_preview.js File chrome/browser/resources/print_preview/print_preview.js (right): http://codereview.chromium.org/7715022/diff/1/chrome/browser/resources/print_preview/print_preview.js#newcode809 chrome/browser/resources/print_preview/print_preview.js:809: launchNativePrintDialog); I thought launchNativePrintDialog is for cloud print UI ...

9 years, 4 months ago (2011-08-24 23:30:43 UTC) #2

Lei Zhang

http://codereview.chromium.org/7715022/diff/1/chrome/browser/resources/print_preview/print_preview.js File chrome/browser/resources/print_preview/print_preview.js (right): http://codereview.chromium.org/7715022/diff/1/chrome/browser/resources/print_preview/print_preview.js#newcode809 chrome/browser/resources/print_preview/print_preview.js:809: launchNativePrintDialog); On 2011/08/24 23:30:43, kmadhusu wrote: > I thought ...

9 years, 4 months ago (2011-08-24 23:46:25 UTC) #3

Change committed as 98400

Expand Messages | Collapse Messages