Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7715020: Move P2P code to content namespace. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, jam, Paweł Hajdan Jr., dmaclach+watch_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Move P2P code to content namespace. BUG=None TEST=Compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98294

Patch Set 1 #

Total comments: 22

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -37 lines) Patch
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/p2p_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/p2p_sockets.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/host_address_request.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/host_address_request.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/p2p_transport_impl.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/p2p/p2p_transport_impl.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/p2p_transport_impl_unittest.cc View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M content/renderer/p2p/socket_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/socket_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_view.h View 1 2 3 4 chunks +9 lines, -6 lines 0 comments Download
M content/renderer/render_view.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M remoting/client/ipc_host_resolver.h View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/client/ipc_host_resolver.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
9 years, 4 months ago (2011-08-23 23:51:50 UTC) #1
jam
http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host.cc File content/browser/renderer_host/p2p/socket_host.cc (right): http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host.cc#newcode14 content/browser/renderer_host/p2p/socket_host.cc:14: namespace { no need for this to be in ...
9 years, 4 months ago (2011-08-24 00:24:26 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host.cc File content/browser/renderer_host/p2p/socket_host.cc (right): http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host.cc#newcode14 content/browser/renderer_host/p2p/socket_host.cc:14: namespace { On 2011/08/24 00:24:27, John Abd-El-Malek wrote: > ...
9 years, 4 months ago (2011-08-24 01:57:48 UTC) #3
jam
http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc File content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc (right): http://codereview.chromium.org/7715020/diff/1/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc#newcode20 content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc:20: namespace content { On 2011/08/24 01:57:48, sergeyu wrote: > ...
9 years, 4 months ago (2011-08-24 16:30:53 UTC) #4
Sergey Ulanov
http://codereview.chromium.org/7715020/diff/1/content/renderer/p2p/ipc_socket_factory.cc File content/renderer/p2p/ipc_socket_factory.cc (right): http://codereview.chromium.org/7715020/diff/1/content/renderer/p2p/ipc_socket_factory.cc#newcode17 content/renderer/p2p/ipc_socket_factory.cc:17: namespace { On 2011/08/24 16:30:53, John Abd-El-Malek wrote: > ...
9 years, 4 months ago (2011-08-24 17:35:12 UTC) #5
jam
9 years, 4 months ago (2011-08-24 23:38:42 UTC) #6 
lgtm

http://codereview.chromium.org/7715020/diff/1/content/renderer/p2p/ipc_socket...
File content/renderer/p2p/ipc_socket_factory.cc (right):

http://codereview.chromium.org/7715020/diff/1/content/renderer/p2p/ipc_socket...
content/renderer/p2p/ipc_socket_factory.cc:17: namespace {
On 2011/08/24 17:35:12, sergeyu wrote:
> On 2011/08/24 16:30:53, John Abd-El-Malek wrote:
> > On 2011/08/24 01:57:48, sergeyu wrote:
> > > On 2011/08/24 00:24:27, John Abd-El-Malek wrote:
> > > > ditto
> > > Putting this code in content namespace makets it simpler, because I don't
> need
> > > to specify namespace when accessing classes from content namespace.
> > 
> > it seems a little odd having an anonymous namespace inside of another
> namespace.
> > if you don't want to keep putting content::, you can just do "using
> > content::P2PBlah.." for the classes that you need, like what we do with
WebKit
> > classes
> 
> Actually there is a lot of code in chrome that defines anonymous namespace
> inside of another namespace and it never caused any problems. Some random
> examples I found (and there are many more):
>  base/callback_unittest.cc
>  base/json/json_reader.cc
>  base/linked_list_unittest.cc
>  net/base/address_list.cc
>  net/base/address_list_unittest.cc
>  net/socket/client_socket_factory.cc
>  net/socket/tcp_client_socket_unittest.cc
>  remoting/*/*

to be clear, I didn't say it caused problems. if there are other places doing
this, then ok

Powered by Google App Engine
This is Rietveld 408576698