Update upload.py from rietveld @ 7696eca367d2.

Update upload.py from rietveld @ 7696eca367d2.

---

Trap failure to get password from keyring

It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97909

[Dirk Pranke, 2011-08-23 20:13:27]

http://codereview.chromium.org/7715013/diff/1/third_party/upload.py
File third_party/upload.py (right):

http://codereview.chromium.org/7715013/diff/1/third_party/upload.py#newcode625
third_party/upload.py:625: # gnomekeyring.IOError inherits from object. :/
I don't get this; you're saying that you can't check the type of the exception
at all? Can you retrieve it from sys.exc_info() and check the type that way?

[M-A Ruel, 2011-08-23 20:14:36]

http://codereview.chromium.org/7715013/diff/1/third_party/upload.py
File third_party/upload.py (right):

http://codereview.chromium.org/7715013/diff/1/third_party/upload.py#newcode625
third_party/upload.py:625: # gnomekeyring.IOError inherits from object. :/
On 2011/08/23 20:13:27, Dirk Pranke wrote:
> I don't get this; you're saying that you can't check the type of the exception
> at all? Can you retrieve it from sys.exc_info() and check the type that way?

No, that the keyring module is a leaky abstraction. Depending if you get the
gnome keyring or the macosx keychain, the exception will be different without
any common base class.

[Dirk Pranke, 2011-08-23 20:17:13]

On Tue, Aug 23, 2011 at 1:14 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/7715013/diff/1/third_party/upload.py
> File third_party/upload.py (right):
>
> http://codereview.chromium.org/7715013/diff/1/third_party/upload.py#newcode625
> third_party/upload.py:625: # gnomekeyring.IOError inherits from object.
> :/
> On 2011/08/23 20:13:27, Dirk Pranke wrote:
>>
>> I don't get this; you're saying that you can't check the type of the
>
> exception
>
>> at all? Can you retrieve it from sys.exc_info() and check the type
>
> that way?
>
> No, that the keyring module is a leaky abstraction. Depending if you get
> the gnome keyring or the macosx keychain, the exception will be
> different without any common base class.
>

Can't you catch the two exceptions in different except blocks? Or in
an if statement using the values returned from sys.exc_info() as I
suggested?

-- Dirk

[Dirk Pranke, 2011-08-23 20:17:50]

On Tue, Aug 23, 2011 at 1:14 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/7715013/diff/1/third_party/upload.py
> File third_party/upload.py (right):
>
> http://codereview.chromium.org/7715013/diff/1/third_party/upload.py#newcode625
> third_party/upload.py:625: # gnomekeyring.IOError inherits from object.
> :/
> On 2011/08/23 20:13:27, Dirk Pranke wrote:
>>
>> I don't get this; you're saying that you can't check the type of the
>
> exception
>
>> at all? Can you retrieve it from sys.exc_info() and check the type
>
> that way?
>
> No, that the keyring module is a leaky abstraction. Depending if you get
> the gnome keyring or the macosx keychain, the exception will be
> different without any common base class.
>

Can't you catch the two exceptions in different except blocks? Or in
an if statement using the values returned from sys.exc_info() as I
suggested?

-- Dirk

[M-A Ruel, 2011-08-23 20:19:49]

On 2011/08/23 20:17:13, Dirk Pranke wrote:
> > No, that the keyring module is a leaky abstraction. Depending if you get
> > the gnome keyring or the macosx keychain, the exception will be
> > different without any common base class.
> >
> 
> Can't you catch the two exceptions in different except blocks? Or in
> an if statement using the values returned from sys.exc_info() as I
> suggested?

From a quick search, there's an awful lot of different exceptions that can be
thrown and it's a bit messy to survey as the implementation is in a .so.

No need to use sys.exc_info() per se, trapping object would probably work. I
just have nothing to do with the exception.

I could import gnomekeyring and check gnomekeyring.IOError but that wouldn't
improve anything here.

[Dirk Pranke, 2011-08-23 20:23:23]

On 2011/08/23 20:19:49, Marc-Antoine Ruel wrote:
> On 2011/08/23 20:17:13, Dirk Pranke wrote:
> > > No, that the keyring module is a leaky abstraction. Depending if you get
> > > the gnome keyring or the macosx keychain, the exception will be
> > > different without any common base class.
> > >
> > 
> > Can't you catch the two exceptions in different except blocks? Or in
> > an if statement using the values returned from sys.exc_info() as I
> > suggested?
> 
> From a quick search, there's an awful lot of different exceptions that can be
> thrown and it's a bit messy to survey as the implementation is in a .so.
> 
> No need to use sys.exc_info() per se, trapping object would probably work. I
> just have nothing to do with the exception.
> 
> I could import gnomekeyring and check gnomekeyring.IOError but that wouldn't
> improve anything here.

Okay, if it's not easy to figure out which exceptions might legitimately be
thrown, that's fine.

I'm just not usually very comfortable with a blanket catch like this, but this
seems fairly low risk.

LGTM.