Issue 7715012: Make unit_tests runnable on Lion without crashing. Now tests just fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7715012: Make unit_tests runnable on Lion without crashing. Now tests just fail. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make unit_tests runnable on Lion without crashing. Now tests just fail. The following tests fail: BrowserWindowFullScreenControllerTest.TestFullscreenNotLion BrowserWindowFullScreenControllerTest.TestActivateNotLion FramedBrowserWindowTest.WindowWidgetLocation HoverImageButtonTest.ImageSwap HoverImageButtonTest.Opacity BUG=93925, 93926 TEST=Run unit_tests on Lion and don't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98228

Patch Set 1 #

Patch Set 2 : Remove the autocomplete_text_field change #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/browser_window_controller_unittest.mm	View		4 chunks	+10 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/hover_image_button_unittest.mm	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages