Update proxy for PPP_Printing_Dev to deal with new QuerySupportedFormats

src/shared/ppapi_proxy/browser_ppp_printing.cc

 // Copyright (c) 2011 The Native Client Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_client/src/shared/ppapi_proxy/browser_ppp_printing.h"
 
-// Include file order cannot be observed because ppp_instance declares a
-// structure return type that causes an error on Windows.
-// TODO(sehr, brettw): fix the return types and include order in PPAPI.
-#include "native_client/src/third_party/ppapi/c/pp_instance.h"
-#include "native_client/src/third_party/ppapi/c/pp_resource.h"
-#include "srpcgen/ppp_rpc.h"
 #include "native_client/src/include/portability.h"
 #include "native_client/src/shared/ppapi_proxy/browser_globals.h"
 #include "native_client/src/shared/ppapi_proxy/browser_ppp.h"
+#include "native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h"

[elijahtaylor (use chromium), 2011/08/24 20:08:23]

Is this include kosher?  I see in other files:

#include "srpcgen/ppp_rpc.h"

[dmichael (off chromium), 2011/08/24 21:21:30]

I would contend that all the other code is wrong :-)

The 'srpcgen/ppp_rpc.h' is a relative path, which goes against guidelines and
triggers a pre-submit warning.

[elijahtaylor (use chromium), 2011/08/24 21:55:28]

How very enlightened :P

Can you check with Polina on this and get her take on it?  There may be a valid
reason why it *should* be the other way despite style guidelines.

 #include "native_client/src/shared/ppapi_proxy/utility.h"
+#include "native_client/src/third_party/ppapi/c/pp_instance.h"
+#include "native_client/src/third_party/ppapi/c/pp_resource.h"
 
 namespace ppapi_proxy {
 
 namespace {
 
-const nacl_abi_size_t kPPPrintOutputFormatBytes =
-    static_cast<nacl_abi_size_t>(sizeof(PP_PrintOutputFormat_Dev));
 const nacl_abi_size_t kPPPrintSettingsBytes =
     static_cast<nacl_abi_size_t>(sizeof(struct PP_PrintSettings_Dev));
 const nacl_abi_size_t kPPPrintPageNumberRangeBytes =
     static_cast<nacl_abi_size_t>(sizeof(struct PP_PrintPageNumberRange_Dev));
 
-PP_PrintOutputFormat_Dev* QuerySupportedFormats(PP_Instance instance,
-                                                uint32_t* format_count) {
+uint32_t QuerySupportedFormats(PP_Instance instance) {
   DebugPrintf("PPP_Printing_Dev::QuerySupportedFormats: "
               "instance=%"NACL_PRIu32"\n", instance);
 
-  const PPB_Memory_Dev* ppb_memory = PPBMemoryInterface();
-  const nacl_abi_size_t kMaxFormats = 8;
-  nacl_abi_size_t formats_bytes = kMaxFormats * kPPPrintOutputFormatBytes;
-  char* formats =
-      reinterpret_cast<char*>(ppb_memory->MemAlloc(formats_bytes));
+  uint32_t formats = 0;
   NaClSrpcError srpc_result =
       PppPrintingRpcClient::PPP_Printing_QuerySupportedFormats(
           GetMainSrpcChannel(instance),
           instance,
-          &formats_bytes, formats,
-          reinterpret_cast<int32_t*>(format_count));
+          reinterpret_cast<int32_t*>(formats));
 
   DebugPrintf("PPP_Printing_Dev::QuerySupportedFormats: %s\n",
               NaClSrpcErrorString(srpc_result));
 
-  if (*format_count > 0)
-    return reinterpret_cast<PP_PrintOutputFormat_Dev*>(formats);
-
-  ppb_memory->MemFree(formats);
-  return NULL;
+  return formats;
 }
 
 int32_t Begin(PP_Instance instance,
               const struct PP_PrintSettings_Dev* print_settings) {
   DebugPrintf("PPP_Printing_Dev::Begin: instance=%"NACL_PRIu32"\n", instance);
 
   int32_t pages_required = 0;
   NaClSrpcError srpc_result =
       PppPrintingRpcClient::PPP_Printing_Begin(
           GetMainSrpcChannel(instance),
@@ skipping 47 matching lines @@
     QuerySupportedFormats,
     Begin,
     PrintPages,
     End
   };
   return &printing_interface;
 }
 
 }  // namespace ppapi_proxy