Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: chrome/browser/prefs/pref_service.h

Issue 7714038: Reverts debugging code added in hopes of tracking crash. This also (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/prefs/incognito_user_pref_store.cc ('k') | chrome/browser/prefs/pref_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This provides a way to access the application's current preferences. 5 // This provides a way to access the application's current preferences.
6 6
7 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_H_ 7 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_H_
8 #define CHROME_BROWSER_PREFS_PREF_SERVICE_H_ 8 #define CHROME_BROWSER_PREFS_PREF_SERVICE_H_
9 #pragma once 9 #pragma once
10 10
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // A helper method to quickly look up a preference. Returns NULL if the 286 // A helper method to quickly look up a preference. Returns NULL if the
287 // preference is not registered. 287 // preference is not registered.
288 const Preference* FindPreference(const char* pref_name) const; 288 const Preference* FindPreference(const char* pref_name) const;
289 289
290 bool ReadOnly() const; 290 bool ReadOnly() const;
291 291
292 // SyncableService getter. 292 // SyncableService getter.
293 // TODO(zea): Have PrefService implement SyncableService directly. 293 // TODO(zea): Have PrefService implement SyncableService directly.
294 SyncableService* GetSyncableService(); 294 SyncableService* GetSyncableService();
295 295
296 // TODO(sky): remove this. It's used in tracking 91396.
297 // Used for debugging. Crashes if the value at |path| is deleted out from
298 // under us.
299 void CheckIfValueDestroyed(const char* path, base::Value::Type type);
300
301 protected: 296 protected:
302 // Construct a new pref service, specifying the pref sources as explicit 297 // Construct a new pref service, specifying the pref sources as explicit
303 // PrefStore pointers. This constructor is what CreatePrefService() ends up 298 // PrefStore pointers. This constructor is what CreatePrefService() ends up
304 // calling. It's also used for unit tests. 299 // calling. It's also used for unit tests.
305 PrefService(PrefStore* managed_platform_prefs, 300 PrefService(PrefStore* managed_platform_prefs,
306 PrefStore* managed_cloud_prefs, 301 PrefStore* managed_cloud_prefs,
307 PrefStore* extension_prefs, 302 PrefStore* extension_prefs,
308 PrefStore* command_line_prefs, 303 PrefStore* command_line_prefs,
309 PersistentPrefStore* user_prefs, 304 PersistentPrefStore* user_prefs,
310 PrefStore* recommended_platform_prefs, 305 PrefStore* recommended_platform_prefs,
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 // of registered preferences are. 390 // of registered preferences are.
396 mutable PreferenceSet prefs_; 391 mutable PreferenceSet prefs_;
397 392
398 // The model associator that maintains the links with the sync db. 393 // The model associator that maintains the links with the sync db.
399 scoped_ptr<PrefModelAssociator> pref_sync_associator_; 394 scoped_ptr<PrefModelAssociator> pref_sync_associator_;
400 395
401 DISALLOW_COPY_AND_ASSIGN(PrefService); 396 DISALLOW_COPY_AND_ASSIGN(PrefService);
402 }; 397 };
403 398
404 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_H_ 399 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/incognito_user_pref_store.cc ('k') | chrome/browser/prefs/pref_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698