Issue 7714030: Add mock classes for Bus, ObjectProxy, and ExportedObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7714030: Add mock classes for Bus, ObjectProxy, and ExportedObject. (Closed)

Created:
9 years, 4 months ago by satorux1

Modified:
9 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add mock classes for Bus, ObjectProxy, and ExportedObject. Also add mock_unittest.cc that demonstrates how to mock synchronos and asynchronos D-Bus method calls. BUG=90036 TEST=dbus_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98188

Patch Set 1 #

Patch Set 2 : fix clang build #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -7 lines)			Patch
M	dbus/bus.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	dbus/dbus.gyp	View		2 chunks	+27 lines, -4 lines	0 comments	Download
M	dbus/exported_object.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
A	dbus/mock_bus.h	View	1	1 chunk	+70 lines, -0 lines	2 comments	Download
A	dbus/mock_bus.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	dbus/mock_exported_object.h	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	dbus/mock_exported_object.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	dbus/mock_object_proxy.h	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	dbus/mock_object_proxy.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	dbus/mock_unittest.cc	View		1 chunk	+171 lines, -0 lines	0 comments	Download
M	dbus/object_proxy.h	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

LGTM http://codereview.chromium.org/7714030/diff/1012/dbus/mock_bus.h File dbus/mock_bus.h (right): http://codereview.chromium.org/7714030/diff/1012/dbus/mock_bus.h#newcode10 dbus/mock_bus.h:10: #include "testing/gmock/include/gmock/gmock.h" nit: + empty line

9 years, 4 months ago (2011-08-25 00:12:54 UTC) #2

satorux1

9 years, 4 months ago (2011-08-25 05:17:08 UTC) #3

http://codereview.chromium.org/7714030/diff/1012/dbus/mock_bus.h
File dbus/mock_bus.h (right):

http://codereview.chromium.org/7714030/diff/1012/dbus/mock_bus.h#newcode10
dbus/mock_bus.h:10: #include "testing/gmock/include/gmock/gmock.h"
On 2011/08/25 00:12:54, Steven Bennetts wrote:
> nit: + empty line

Done.

Expand Messages | Collapse Messages