Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 7714024: Remove check_on_delete for ChromeOS to avoid change to sizeof(Value) (Closed)

Created:
9 years, 4 months ago by stevenjb
Modified:
9 years, 4 months ago
Reviewers:
brettw, satorux1, sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove check_on_delete for ChromeOS to avoid change to sizeof(Value) BUG=chromium-os:19577 TEST=chrome compiles on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M base/values.h View 2 chunks +8 lines, -0 lines 0 comments Download
M base/values.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
Not the prettiest fix, but by far the easiest to do quickly and un-break the ...
9 years, 4 months ago (2011-08-24 00:56:11 UTC) #1
satorux1
LGTM Makes sense as a temporary fix.
9 years, 4 months ago (2011-08-24 01:00:40 UTC) #2
sky
LGTM, but I'm not an owner. I added Brett to the reviewers list. -Scott
9 years, 4 months ago (2011-08-24 02:19:21 UTC) #3
brettw
9 years, 4 months ago (2011-08-24 05:06:05 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698