Removing old histograms for measuring RTT vs Kilobytes of data

net/http/http_basic_stream.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_basic_stream.h"
 
 #include "base/format_macros.h"
 #include "base/metrics/histogram.h"
 #include "base/stringprintf.h"
 #include "net/base/io_buffer.h"
@@ skipping 124 matching lines @@
   int64 total_bytes_read = connection_->socket()->NumBytesRead();
   int64 bytes_received = total_bytes_read - bytes_read_offset_;
   int64 num_kb = bytes_received / 1024;
   double rtt = connection_->socket()->GetConnectTimeMicros().ToInternalValue();
   rtt /= 1000.0;
 
   if (num_kb < 1024 && rtt > 0) {  // Ignore responses > 1MB
     base::TimeDelta duration = base::Time::Now() -
                                response_->request_time;
     double num_rtt = static_cast<double>(duration.InMilliseconds()) / rtt;
-    int64 num_rtt_scaled = (4 * num_rtt);
-
-    static const char* const kGroups[] = {
-      "warmest_socket", "warm_socket", "last_accessed_socket"
-    };
-    int bucket = (num_kb / 5) * 5;
-    const std::string histogram(StringPrintf("Net.Num_RTT_vs_KB_%s_%dKB",
-                                             kGroups[socket_reuse_policy],
-                                             bucket));
-    base::Histogram* counter = base::Histogram::FactoryGet(
-        histogram, 0, 1000, 2, base::Histogram::kUmaTargetedHistogramFlag);
-    DCHECK_EQ(histogram, counter->histogram_name());
-    counter->Add(num_rtt_scaled);
 
     VLOG(2) << StringPrintf("%s\nrtt = %f\tnum_rtt = %f\t"

[jar (doing other things), 2011/08/23 23:01:35]

What does VLOG do?

IMO, this should all be debug code, as it probably has no significant use.  The
call on line 142 to acquire a duration seems like a waste (central call to get a
locked resource, which is Now()).

Have you considered getting rid of this whole function?.... or worst case,
making it only produce output when some debug flag is set?

For instance, the entire body of this function could be conditioned away with
 if (!VLOG_IS_ON(2)) return;
on line 130.

[gagansingh, 2011/08/24 00:03:29]

This log was very helpful in the initial development phase.
i had missed a read in tcp socket and was getting lesser bytes read than the
resource size, and this was useful then. probably useless now.
plz let me know if youd like this removed, for now ive just enabled this with
VLOG_IS_ON(2)

                             "num_kb = %" PRId64 "\t"
-                            "total bytes = %" PRId64 "\t"
-                            "histogram = %s",
+                            "total bytes = %" PRId64,
                             request_line_.data(),
-                            rtt, num_rtt, num_kb, total_bytes_read,
-                            histogram.data());
+                            rtt, num_rtt, num_kb, total_bytes_read);
   }
 }
 
 }  // namespace net