Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: content/renderer/pepper_plugin_delegate_impl.cc

Issue 7714017: Reimplement the Pepper fullscreen API to use webkitRequestFullScreen and friends. (Closed) Base URL: ssh://matter.syd/usr/local/google/chromium2/src@master
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper_plugin_delegate_impl.cc
diff --git a/content/renderer/pepper_plugin_delegate_impl.cc b/content/renderer/pepper_plugin_delegate_impl.cc
index 0476e532d3c2a168bb128534eac608e5cbcb648d..de6f3b108ccae42eef9a8a9ae2c2f1df43cb92e3 100644
--- a/content/renderer/pepper_plugin_delegate_impl.cc
+++ b/content/renderer/pepper_plugin_delegate_impl.cc
@@ -1298,13 +1298,6 @@ int32_t PepperPluginDelegateImpl::ShowContextMenu(
webkit::ppapi::PPB_Flash_Menu_Impl* menu,
const gfx::Point& position) {
int32 render_widget_id = render_view_->routing_id();
- if (instance->IsFullscreen(instance->pp_instance())) {
- webkit::ppapi::FullscreenContainer* container =
- instance->fullscreen_container();
- DCHECK(container);
- render_widget_id =
- static_cast<RenderWidgetFullscreenPepper*>(container)->routing_id();
- }
int request_id = pending_context_menus_.Add(
new scoped_refptr<webkit::ppapi::PPB_Flash_Menu_Impl>(menu));
@@ -1368,10 +1361,10 @@ void PepperPluginDelegateImpl::OnCustomContextMenuAction(
saved_context_menu_action_ = action;
}
-webkit::ppapi::FullscreenContainer*
-PepperPluginDelegateImpl::CreateFullscreenContainer(
- webkit::ppapi::PluginInstance* instance) {
- return render_view_->CreatePepperFullscreenContainer(instance);
+void PepperPluginDelegateImpl::SetFullscreen(
brettw 2011/08/24 23:14:04 Do we even need this function anymore? The code in
jeremya 2011/08/24 23:40:45 Done. Good catch :)
+ webkit::ppapi::PluginInstance* instance,
+ bool fullscreen) {
+ instance->container()->setFullscreen(fullscreen);
}
gfx::Size PepperPluginDelegateImpl::GetScreenSize() {

Powered by Google App Engine
This is Rietveld 408576698