File Manager: fix date sorting initialization

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 121 matching lines @@
     this.onFileTaskExecute_.bind(this));
 
   this.initCommands_();
   this.initDom_();
   this.initDialogType_();
   this.setupCurrentDirectory_();
 
   this.summarizeSelection_();
   this.updatePreview_();
 
+  this.dataModel_.sort('cachedMtime_');
+
   this.refocus();
 
   // Pass all URLs to the metadata reader until we have a correct filter.
   this.metadataUrlFilter_ = /.*/;
 
   this.metadataReader_ = new Worker('js/metadata_dispatcher.js');
   this.metadataReader_.onmessage = this.onMetadataMessage_.bind(this);
   this.metadataReader_.postMessage({verb: 'init'});
   // Initialization is not complete until the Worker sends back the
   // 'initialized' message.  See below.
@@ skipping 476 matching lines @@
 
     this.dataModel_ = new cr.ui.ArrayDataModel([]);
     var collator = this.collator_;
     this.dataModel_.setCompareFunction('name', function(a, b) {
       return collator.compare(a.name, b.name);
     });
     this.dataModel_.setCompareFunction('cachedMtime_',
                                        this.compareMtime_.bind(this));
     this.dataModel_.setCompareFunction('cachedSize_',
                                        this.compareSize_.bind(this));
-    this.dataModel_.sort('cachedMtime_');
     this.dataModel_.prepareSort = this.prepareSort_.bind(this);
 
     if (this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FILE ||
         this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FOLDER ||
         this.dialogType_ == FileManager.DialogType.SELECT_SAVEAS_FILE) {
       this.selectionModelClass_ = cr.ui.ListSingleSelectionModel;
     } else {
       this.selectionModelClass_ = cr.ui.ListSelectionModel;
     }
 
     this.initTable_();
     this.initGrid_();
 
     this.setListType(FileManager.ListType.DETAIL);
 
     this.onResize_();
     this.dialogDom_.style.opacity = '1';
 
     this.textSearchState_ = {text: '', date: new Date()};
   };
 
   /**
    * Compare by mtime first, then by name.
    */
   FileManager.prototype.compareMtime_ = function(a, b) {
-    if (a.cachedMtime_ > b.cachedMtime)
+    if (a.cachedMtime_ > b.cachedMtime_)
       return 1;
 
-    if (a.cachedMtime_ < b.cachedMtime)
+    if (a.cachedMtime_ < b.cachedMtime_)
       return -1;
 
     return this.collator_.compare(a.name, b.name);
   };
 
   /**
    * Compare by size first, then by name.
    */
   FileManager.prototype.compareSize_ = function(a, b) {
-    if (a.cachedSize_ > b.cachedSize)
+    if (a.cachedSize_ > b.cachedSize_)
       return 1;
 
-    if (a.cachedSize_ < b.cachedSize)
+    if (a.cachedSize_ < b.cachedSize_)
       return -1;
 
     return this.collator_.compare(a.name, b.name);
   };
 
   FileManager.prototype.refocus = function() {
     this.document_.querySelector('[tabindex="0"]').focus();
   };
 
   FileManager.prototype.showButter = function(message, opt_options) {
@@ skipping 2454 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();