Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 7714007: Apply content-security-policy directive to chrome://workers page. (Closed)

Created:
9 years, 4 months ago by Tom Sepez
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Nirnimesh, John Grabowski, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., dennis_jeffrey, anantha
Visibility:
Public.

Description

Apply content-security-policy directive to chrome://workers page. The changes to chrome_web_ui_data_source allow for alternate message loops and the absence of translated strings, which are cases I didn't think we'd encounter. But we did. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98110

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -76 lines) Patch
M chrome/browser/resources/workers/index.html View 2 chunks +8 lines, -51 lines 0 comments Download
A chrome/browser/resources/workers/workers.js View 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/browser/resources/workers_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.cc View 3 chunks +12 lines, -2 lines 2 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 2 chunks +5 lines, -21 lines 0 comments Download
M chrome/test/functional/special_tabs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Found another one. Please review.
9 years, 4 months ago (2011-08-23 19:07:47 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/7714007/diff/2002/chrome/browser/ui/webui/chrome_web_ui_data_source.cc File chrome/browser/ui/webui/chrome_web_ui_data_source.cc (right): http://codereview.chromium.org/7714007/diff/2002/chrome/browser/ui/webui/chrome_web_ui_data_source.cc#newcode55 chrome/browser/ui/webui/chrome_web_ui_data_source.cc:55: if (!json_path_.empty() && path == json_path_) { I ...
9 years, 4 months ago (2011-08-24 20:47:23 UTC) #2
Tom Sepez
9 years, 4 months ago (2011-08-24 20:52:36 UTC) #3
http://codereview.chromium.org/7714007/diff/2002/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chrome_web_ui_data_source.cc (right):

http://codereview.chromium.org/7714007/diff/2002/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chrome_web_ui_data_source.cc:55: if (!json_path_.empty()
&& path == json_path_) {
Not quite.  json_path_ can be empty if the particular source doesn't have any
json to return, and thus hasn't called set_json_path().  We don't want to take
this path unless the json_path has been set.

Powered by Google App Engine
This is Rietveld 408576698