Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3161)

Unified Diff: chrome/browser/chromeos/cros/native_network_parser.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: convert one more case in extension_webrequest_api_unittest.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/native_network_parser.cc
diff --git a/chrome/browser/chromeos/cros/native_network_parser.cc b/chrome/browser/chromeos/cros/native_network_parser.cc
index 31720250ea9fbbe3c87c1ac519809028a95d30e1..1c063fdfa4ee93c6dc31e6aea9524579719642b8 100644
--- a/chrome/browser/chromeos/cros/native_network_parser.cc
+++ b/chrome/browser/chromeos/cros/native_network_parser.cc
@@ -194,27 +194,24 @@ bool NativeNetworkDeviceParser::ParseValue(
return true;
}
case PROPERTY_INDEX_CELLULAR_APN_LIST:
- if (value.IsType(Value::TYPE_LIST)) {
+ if (ListValue* list = value.AsList()) {
CellularApnList provider_apn_list;
- if (!ParseApnList(static_cast<const ListValue&>(value),
- &provider_apn_list))
+ if (!ParseApnList(list, &provider_apn_list))
return false;
device->set_provider_apn_list(provider_apn_list);
return true;
}
break;
case PROPERTY_INDEX_NETWORKS:
- if (value.IsType(Value::TYPE_LIST)) {
+ if (value.AsList()) {
// Ignored.
return true;
}
break;
case PROPERTY_INDEX_FOUND_NETWORKS:
- if (value.IsType(Value::TYPE_LIST)) {
+ if (ListValue* list = value.AsList()) {
CellularNetworkList found_cellular_networks;
- if (!ParseFoundNetworksFromList(
- static_cast<const ListValue&>(value),
- &found_cellular_networks))
+ if (!ParseFoundNetworksFromList(list, &found_cellular_networks))
return false;
device->set_found_cellular_networks(found_cellular_networks);
return true;

Powered by Google App Engine
This is Rietveld 408576698