chrome/browser/extensions/extension_bookmarks_module.cc - Issue 7714004: base: Add AsList() function to Value API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more poor const_casts Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_bookmarks_module.cc

diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc

index dce4b6f02ee1a1f370ec643469b3f0041d92cae9..f8b2c785017c5d58ec9db4902dc37883e84bb946 100644

--- a/chrome/browser/extensions/extension_bookmarks_module.cc

+++ b/chrome/browser/extensions/extension_bookmarks_module.cc

@@ -285,8 +285,7 @@ bool GetBookmarksFunction::RunImpl() {

scoped_ptr<ListValue> json(new ListValue());

Value* arg0;

EXTENSION_FUNCTION_VALIDATE(args_->Get(0, &arg0));

- if (arg0->IsType(Value::TYPE_LIST)) {

- const ListValue* ids = static_cast<const ListValue*>(arg0);

+ if (const ListValue* ids = arg0->AsList()) {

size_t count = ids->GetSize();

EXTENSION_FUNCTION_VALIDATE(count > 0);

for (size_t i = 0; i < count; ++i) {