base/values_unittest.cc - Issue 7714004: base: Add AsList() function to Value API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 7714004: base: Add AsList() function to Value API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chromeos Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index 553e8e15080a083712232ee45b21b077e6fb99de..c8d3e3ca11d6429731a3c5b718a73bfe27911122 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -429,8 +429,8 @@ TEST(ValuesTest, DeepCopy) {

ASSERT_TRUE(copy_dict->Get("list", &copy_value));

ASSERT_TRUE(copy_value);

ASSERT_NE(copy_value, original_list);

- ASSERT_TRUE(copy_value->IsType(Value::TYPE_LIST));

- ListValue* copy_list = static_cast<ListValue*>(copy_value);

+ ListValue* copy_list = copy_value->AsList();

+ ASSERT_TRUE(copy_list != NULL);

ASSERT_EQ(2U, copy_list->GetSize());

Value* copy_list_element_0;

« no previous file with comments | « base/values.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »