Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/cookies_tree_model_unittest.cc

Issue 7713034: HostContentSettingsMap refactoring. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Code review comments. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cookies_tree_model_unittest.cc
diff --git a/chrome/browser/cookies_tree_model_unittest.cc b/chrome/browser/cookies_tree_model_unittest.cc
index 65cb895d95bde98389bb36a4b52d2b98561d46ee..ca7f82460def467bda871c3d4013c15403219a84 100644
--- a/chrome/browser/cookies_tree_model_unittest.cc
+++ b/chrome/browser/cookies_tree_model_unittest.cc
@@ -6,6 +6,8 @@
#include <string>
+#include "chrome/browser/content_settings/cookie_settings.h"
+#include "chrome/browser/content_settings/cookie_settings_factory.h"
#include "chrome/browser/content_settings/host_content_settings_map.h"
#include "chrome/browser/content_settings/mock_settings_observer.h"
#include "chrome/browser/mock_browsing_data_appcache_helper.h"
@@ -948,6 +950,8 @@ TEST_F(CookiesTreeModelTest, ContentSettings) {
TestingProfile profile;
HostContentSettingsMap* content_settings =
profile.GetHostContentSettingsMap();
+ CookieSettings* cookie_settings =
+ CookieSettingsFactory::GetForProfile(&profile);
MockSettingsObserver observer;
CookieTreeRootNode* root =
@@ -965,16 +969,33 @@ TEST_F(CookiesTreeModelTest, ContentSettings) {
ContentSettingsPattern::Wildcard(),
false));
EXPECT_CALL(observer,
- OnContentSettingsChanged(content_settings,
+ OnContentSettingsChanged(
+ content_settings,
CONTENT_SETTINGS_TYPE_COOKIES,
false,
ContentSettingsPattern::FromURL(host),
ContentSettingsPattern::Wildcard(),
false));
+ EXPECT_CALL(observer,
+ OnContentSettingsChanged(
+ content_settings,
+ CONTENT_SETTINGS_TYPE_COOKIES_SESSION_ONLY,
+ false,
+ ContentSettingsPattern::FromURLNoWildcard(host),
+ ContentSettingsPattern::Wildcard(),
+ false));
+ EXPECT_CALL(observer,
+ OnContentSettingsChanged(
+ content_settings,
+ CONTENT_SETTINGS_TYPE_COOKIES_SESSION_ONLY,
+ false,
+ ContentSettingsPattern::FromURL(host),
+ ContentSettingsPattern::Wildcard(),
+ false));
origin->CreateContentException(
- content_settings, CONTENT_SETTING_SESSION_ONLY);
- EXPECT_EQ(CONTENT_SETTING_SESSION_ONLY,
- content_settings->GetCookieContentSetting(host, host, true));
+ cookie_settings, CONTENT_SETTING_SESSION_ONLY);
+ EXPECT_TRUE(cookie_settings->IsSettingCookieAllowed(host, host));
+ EXPECT_TRUE(cookie_settings->IsCookieSessionOnly(host));
}
TEST_F(CookiesTreeModelTest, FileSystemFilter) {

Powered by Google App Engine
This is Rietveld 408576698