webkit/glue/p2p_transport.cc - Issue 7713021: Add SetProperty() in the PPB_Transport_Dev interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/glue/p2p_transport.cc

Issue 7713021: Add SetProperty() in the PPB_Transport_Dev interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "webkit/glue/p2p_transport.h"

	6

	7 namespace webkit_glue {

	8

	9 P2PTransport::Config::Config()

	10 : tcp_receive_window(0),

	11 tcp_send_window(0) {

	12 }

	13

	14 P2PTransport::Config::~Config() { }
	brettw 2011/08/25 16:48:43 Style guide says no space in {} (in this case I'd Style guide says no space in {} (in this case I'd actually put the } on the next line, personally, since in the .cc file it's no less clear if it's one line longer. Sergey Ulanov 2011/08/25 17:36:53 Done. Personally I prefer to have space here, and Show quoted text On 2011/08/25 16:48:43, brettw wrote: > Style guide says no space in {} (in this case I'd actually put the } on the next > line, personally, since in the .cc file it's no less clear if it's one line > longer. Done. Personally I prefer to have space here, and there is a lot of code that does have space in such cases, e.g. ~/c/src/base$ grep \{\ \} * \|wc -l 49 I didn't know that the style guide says that there should be no space. Just out of curiosity, can you point out at the specific rule that mentions it. Thanks brettw 2011/08/26 20:24:06 http://www.corp.google.com/eng/doc/cppguide.xml?sh Show quoted text On 2011/08/25 17:36:53, sergeyu wrote: > On 2011/08/25 16:48:43, brettw wrote: > > Style guide says no space in {} (in this case I'd actually put the } on the > next > > line, personally, since in the .cc file it's no less clear if it's one line > > longer. > Done. > Personally I prefer to have space here, and there is a lot of code that does > have space in such cases, e.g. > ~/c/src/base$ grep \{\ \} * \|wc -l > 49 > I didn't know that the style guide says that there should be no space. Just out > of curiosity, can you point out at the specific rule that mentions it. Thanks http://www.corp.google.com/eng/doc/cppguide.xml?showone=Horizontal_Whitespace... "no spaces inside empty braces" Sergey Ulanov 2011/08/26 20:34:36 Thanks! Show quoted text On 2011/08/26 20:24:06, brettw wrote: > On 2011/08/25 17:36:53, sergeyu wrote: > > On 2011/08/25 16:48:43, brettw wrote: > > > Style guide says no space in {} (in this case I'd actually put the } on the > > next > > > line, personally, since in the .cc file it's no less clear if it's one line > > > longer. > > Done. > > Personally I prefer to have space here, and there is a lot of code that does > > have space in such cases, e.g. > > ~/c/src/base$ grep \{\ \} * \|wc -l > > 49 > > I didn't know that the style guide says that there should be no space. Just > out > > of curiosity, can you point out at the specific rule that mentions it. Thanks > > http://www.corp.google.com/eng/doc/cppguide.xml?showone=Horizontal_Whitespace... > "no spaces inside empty braces" Thanks!
	15

	16 } // namespace webkit_glue

OLD	NEW

« ppapi/tests/test_transport.cc ('K') | « webkit/glue/p2p_transport.h ('k') | webkit/glue/webkit_glue.gypi » ('j') | webkit/plugins/ppapi/ppb_transport_impl.cc » ('J')