Add SetProperty() in the PPB_Transport_Dev interface.

ppapi/c/dev/ppb_transport_dev.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef PPAPI_C_PPB_TRANSPORT_DEV_H_
 #define PPAPI_C_PPB_TRANSPORT_DEV_H_
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_module.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ppapi/c/pp_var.h"
 
 #define PPB_TRANSPORT_DEV_INTERFACE_0_5 "PPB_Transport;0.5"

[brettw, 2011/08/22 23:59:59]

Be sure to rev the interface string.

[Sergey Ulanov, 2011/08/24 17:22:16]

Done.

 #define PPB_TRANSPORT_DEV_INTERFACE PPB_TRANSPORT_DEV_INTERFACE_0_5
 
 struct PPB_Transport_Dev {
   // Creates a new transport object with the specified name using the
   // specified protocol.
   PP_Resource (*CreateTransport)(PP_Instance instance,
                                  const char* name,
                                  const char* proto);
 
   // Returns PP_TRUE if resource is a Transport, PP_FALSE otherwise.
   PP_Bool (*IsTransport)(PP_Resource resource);
 
   // Returns PP_TRUE if the transport is currently writable (i.e. can
   // send data to the remote peer), PP_FALSE otherwise.
   PP_Bool (*IsWritable)(PP_Resource transport);
   // TODO(juberti): other getters/setters
   // connect state
   // connect type, protocol
   // RTT
 
+  // Set STUN/relay server configuration, as well as other
+  // configuration parameters.

[brettw, 2011/08/22 23:59:59]

This documentation gives me no idea what I can pass in config. Can this be
significantly expanded or can you give a pointer to where I can figure this out?
(Maybe a simple example would also be nice.)

Actually, I think I'd prefer something more like the URLRequestInfo where you
have an enum of all the supported options, and then set them individually. I
think this makes the calling code more clear, and it also makes it easier to
tell what options we support. The parameter can be a var so you can pass
integers for things like the receive window and not have to do parsing.

[Sergey Ulanov, 2011/08/23 19:02:04]

I like the idea of SetProperty() and enum with all properties. One problem I see
with this approach is that array support is not yet implemented in PP_Var, and
it would be useful here for specifying stun and relay server addresses. For now
I think I can use comma-separated lists for these parameters, and switch to
arrays later when they are implemented. What do you think about it?

How hard would it be to implement array vars?

+  int32_t (*SetConfig)(PP_Resource transport, const char* config);
+
   // Establishes a connection to the remote peer.  Returns
   // PP_OK_COMPLETIONPENDING and notifies on |cb| when connectivity is
   // established (or timeout occurs).
   int32_t (*Connect)(PP_Resource transport,
                      struct PP_CompletionCallback cb);
 
   // Obtains another ICE candidate address to be provided to the
   // remote peer. Returns PP_OK_COMPLETIONPENDING if there are no more
   // addresses to be sent. After the callback is called
   // GetNextAddress() must be called again to get the address.
@@ skipping 18 matching lines @@
   int32_t (*Send)(PP_Resource transport,
                   const void* data,
                   uint32_t len,
                   struct PP_CompletionCallback cb);
 
   // Disconnects from the remote peer.
   int32_t (*Close)(PP_Resource transport);
 };
 
 #endif  /* PPAPI_C_PPB_TRANSPORT_DEV_H_ */