Issue 7712022: This patch caused Chrome to be unable to load any web pages on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7712022: This patch caused Chrome to be unable to load any web pages on Chrome OS. (Closed)

Created:
9 years, 4 months ago by satorux1

Modified:
9 years, 4 months ago

Reviewers:
yoshiki, brettw, James Cook

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

This patch caused Chrome to be unable to load any web pages on Chrome OS. BUG=chromium-os:19468 TEST=confirm chrome loads pages Revert "Fix IPC OnChannelConnected() to send correct PID on Linux/CrOS" This reverts commit 92321e01ba42f2d0e9508e921f8b440ac0b5319f. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97811

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -146 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/service/service_process_control.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/browser_child_process_host.cc	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	content/browser/renderer_host/browser_render_process_host.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	ipc/ipc_channel.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	ipc/ipc_channel_posix.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	4 chunks	+2 lines, -42 lines	0 comments	Download
M	ipc/ipc_channel_proxy.h	View	5 chunks	+3 lines, -15 lines	0 comments	Download
M	ipc/ipc_channel_proxy.cc	View	6 chunks	+7 lines, -32 lines	0 comments	Download
M	ipc/ipc_sync_channel.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ipc/ipc_tests.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

Yoshiki, please check if this fixes crosbug.com/19468. Once it's confirmed, I think we should revert ...

9 years, 4 months ago (2011-08-23 02:21:51 UTC) #1

yoshiki

LGTM. I confirmed that ToT doesn't work and this CL fixes the problem. On 2011/08/23 ...

9 years, 4 months ago (2011-08-23 03:08:36 UTC) #2

LGTM

Expand Messages | Collapse Messages