chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc - Issue 7712001: WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

Issue 7712001: WindowOpenDisposition should not be exposed in base and ui modules. (1) Gdk refactoring (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: minor fix. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

index 39a202b9f99b775c95bb2773cb70e8637225a4db..a35d4a6d2d578133825cbe02a303478cbdadb2a2 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/ui/gtk/gtk_theme_service.h"

#include "chrome/browser/ui/gtk/gtk_util.h"

#include "chrome/browser/ui/gtk/menu_gtk.h"

+#include "chrome/browser/ui/views/event_utils.h"

Elliot Glaysher 2011/08/24 18:04:49 Please move event_utils to a common location; this

shinyak (Google) 2011/08/25 05:54:10 Done. just removed this header file because it is

#include "content/browser/tab_contents/page_navigator.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

@@ -293,7 +294,8 @@ gboolean BookmarkMenuController::OnButtonReleased(

// The menu item is a link node.

if (event->button == 1 || event->button == 2) {

WindowOpenDisposition disposition =

- event_utils::DispositionFromEventFlags(event->state);

+ event_utils::DispositionFromGdkState(event->state);

NavigateToMenuItem(sender, disposition);

// We need to manually dismiss the popup menu because we're overriding

« no previous file with comments | « chrome/browser/event_disposition.cc ('k') | chrome/browser/ui/gtk/gtk_util.h » ('j') | chrome/browser/ui/gtk/gtk_util.cc » ('J')