Issue 7711025: [filebrowser] Fix detection of unmount-archive action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7711025: [filebrowser] Fix detection of unmount-archive action. (Closed)

Created:
9 years, 4 months ago by dgozman

Modified:
9 years, 3 months ago

Reviewers:
rginda, zel

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[filebrowser] Fix detection of unmount-archive action. BUG=chromium-os:19510 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98412

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+13 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rginda

9 years, 4 months ago (2011-08-23 21:09:03 UTC) #2

LGTM, but this should switch to normalizeAbsolutePath() once it exists.

http://codereview.chromium.org/7711025/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7711025/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1686: if (mountPath[0]
!= '/') {
FYI, in http://codereview.chromium.org/7706028/ Szymon is factoring out the
normalize() function from maybeRenderFormattingTask_ into a utility method.

Expand Messages | Collapse Messages