Issue 7711010: Removal of Profile from content part 9 of 9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7711010: Removal of Profile from content part 9 of 9. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removal of Profile from content part 9 of 9. BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97861

Patch Set 1 #

Patch Set 2 : missing mock #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -16 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile.h	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/DEPS	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	content/browser/content_browser_client.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/arbitrator_dependency_factory.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/resolve_proxy_msg_helper.cc	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

jam: fyi miranda: review Yes, I know this is terrible. What else to do, though?

9 years, 4 months ago (2011-08-22 20:25:41 UTC) #1

jam

lgtm You have to modify the mock version as well in mock_content_browser_client

9 years, 4 months ago (2011-08-22 20:39:38 UTC) #2

Avi (use Gerrit)

On 2011/08/22 20:39:38, John Abd-El-Malek wrote: > lgtm > > You have to modify the ...

9 years, 4 months ago (2011-08-22 20:50:44 UTC) #3

Miranda Callahan

9 years, 4 months ago (2011-08-23 15:00:58 UTC) #4

On 2011/08/22 20:50:44, Avi wrote:
> On 2011/08/22 20:39:38, John Abd-El-Malek wrote:
> > lgtm
> > 
> > You have to modify the mock version as well in mock_content_browser_client
> 
> Yeah, found out that real quickly on the trybots.
> 
> Miranda?

Profiles OWNER LGTM. sigh.

Expand Messages | Collapse Messages