Issue 7710018: Fix typo in assert.

Issue 7710018: Fix typo in assert. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 4 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix typo in assert. Also remove the requirement to have an AssertNoAllocation object when getting the flat content. We actually do allow allocation, it's just GC's we don't allow. Committed: http://code.google.com/p/v8/source/detail?r=9001

Patch Set 1 #

Patch Set 2 : Remove AssertNoAllocation requirement too. #

Total comments: 9

Patch Set 3 : Readded missing test #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -52 lines)			Patch
M	src/handles.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1	7 chunks	+8 lines, -16 lines	0 comments	Download
M	src/runtime.cc	View	1	13 chunks	+18 lines, -23 lines	0 comments	Download
M	test/mjsunit/string-split.js	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3051 src/runtime.cc:3051: AssertNoAllocation no_heap_allocation; // ensure vectors stay valid Do ...

9 years, 4 months ago (2011-08-23 13:17:53 UTC) #3

Lasse Reichstein

9 years, 4 months ago (2011-08-23 13:20:49 UTC) #4

http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3051
src/runtime.cc:3051: AssertNoAllocation no_heap_allocation;  // ensure vectors
stay valid
It's an assert, so we don't *need* it, but if it's possible to add it, it's
great. Ditto for the other cases.

http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode5975
src/runtime.cc:5975: AssertNoAllocation nogc;
I reverted part of the previous patch, which contained a rename in the other
direction (which seemed more consistent).
I'll rename it again.

http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js
File test/mjsunit/string-split.js (left):

http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js...
test/mjsunit/string-split.js:120: var all_ascii_chars = [];
Also lost in revert. Will re-add.

Expand Messages | Collapse Messages