Issue 7709026: Heap profiler: for objects of class "Object", try to lookup name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7709026: Heap profiler: for objects of class "Object", try to lookup name (Closed)

Created:
9 years, 4 months ago by mnaganov (inactive)

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Heap profiler: for objects of class "Object", try to lookup name from the constructor function. This works well for binding objects, and this matches DevTools' algorithm for name assignment. R=sgjesse@chromium.org BUG=none TEST=test-heap-profiler/GetConstructorName Committed: http://code.google.com/p/v8/source/detail?r=9000

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -12 lines)			Patch
M	src/profile-generator.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/profile-generator.cc	View	4 chunks	+27 lines, -9 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+52 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/7709026/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): http://codereview.chromium.org/7709026/diff/1/test/cctest/test-heap-profiler.cc#newcode919 test/cctest/test-heap-profiler.cc:919: "var obj6 = {};\n" Why no test using ...

9 years, 4 months ago (2011-08-23 11:34:23 UTC) #2

mnaganov (inactive)

9 years, 4 months ago (2011-08-23 12:24:28 UTC) #3

http://codereview.chromium.org/7709026/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):

http://codereview.chromium.org/7709026/diff/1/test/cctest/test-heap-profiler....
test/cctest/test-heap-profiler.cc:919: "var obj6 = {};\n"
On 2011/08/23 11:34:23, Søren Gjesse wrote:
> Why no test using obj6 below?

Thanks for spotting! Fixed.

Expand Messages | Collapse Messages