Sync Setup UI: Fix Hebrew and Arabic word order on title of dialog.

Sync Setup UI: Fix Hebrew and Arabic word order on title of dialog.

BUG=70295
TEST=Run chrome in Arabic, Hebrew. View chrome://settings/syncSetup. Google should be the leftmost word in the title of the dialog.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98120

[binji, 2011-08-22 22:35:18]

This method of manipulating Unicode text is a total hack, but I'm hesitant to
mess with the strings to fix it.

[arv (Not doing code reviews), 2011-08-23 17:20:43]

LGTM

I'm not fully familiar with how this part. How come the code previously went
through hoops to do this?

[binji, 2011-08-23 17:56:26]

On 2011/08/23 17:20:43, arv wrote:
> LGTM
> 
> I'm not fully familiar with how this part. How come the code previously went
> through hoops to do this?

I'm not certain why it's done this way, but the idea is that there is specific
formatting desired for different parts of the message:

"Sign in to your <img GOOGLE/> <b>Account</b>" is what we want, across different
languages.

As it is now, "Sign in to your" is one string and "Google Account" is the other.
"Google Account" is made bold, and the Google part is removed and replaced with
the logo. Like I said, pretty nasty, but other than the RTL issue here, I
haven't seen complaints.

This is probably going to change to the new sign-in style anyway... :)

[commit-bot: I haz the power, 2011-08-23 23:04:35]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 97904, job name
was 7709012-1 (previous was lost) (previous was lost) (retry) (previous was
lost).

[commit-bot: I haz the power, 2011-08-24 04:50:34]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win, revision is 97985, job name
was 7709012-1 (previous was lost) (retry) (previous was lost) (retry).

[commit-bot: I haz the power, 2011-08-24 21:47:24]

Change committed as 98120