CC:
chromium-reviews, derat+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org, Zachary Kuznia, dmazzoni, Daniel Erat
Adds an extension API of the event on changing volume.
- experimental.accessibility.onVolumeChange
I run chrome/common/extensions/docs/build/build.py, but no documents about a11y was changed. So this CL doesn't include any changes of documents.
BUG=chromium-os:16592
TEST=call the APIs manually on chromium-os
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98948
I had more comments but Dominic beat me to it. :-P http://codereview.chromium.org/7708025/diff/1/chrome/browser/chromeos/system_key_event_listener.cc File chrome/browser/chromeos/system_key_event_listener.cc (right): ...
9 years, 4 months ago
(2011-08-24 14:52:57 UTC)
#3
http://codereview.chromium.org/7708025/diff/14001/chrome/common/extensions/api/extension_api.json File chrome/common/extensions/api/extension_api.json (right): http://codereview.chromium.org/7708025/diff/14001/chrome/common/extensions/api/extension_api.json#newcode513 chrome/common/extensions/api/extension_api.json:513: "$ref": "AccessibilityVolumeInfo", I think you need to add AccessibilityVolumeInfo ...
9 years, 3 months ago
(2011-08-29 09:36:28 UTC)
#6
LGTM with just a couple more issues. http://codereview.chromium.org/7708025/diff/14003/chrome/browser/extensions/extension_accessibility_api_constants.cc File chrome/browser/extensions/extension_accessibility_api_constants.cc (right): http://codereview.chromium.org/7708025/diff/14003/chrome/browser/extensions/extension_accessibility_api_constants.cc#newcode21 chrome/browser/extensions/extension_accessibility_api_constants.cc:21: const char ...
9 years, 3 months ago
(2011-08-29 22:24:06 UTC)
#9
LGTM http://codereview.chromium.org/7708025/diff/14003/chrome/common/extensions/api/extension_api.json File chrome/common/extensions/api/extension_api.json (right): http://codereview.chromium.org/7708025/diff/14003/chrome/common/extensions/api/extension_api.json#newcode391 chrome/common/extensions/api/extension_api.json:391: "volume": {"type": "double", "description": "The value of the ...
9 years, 3 months ago
(2011-08-30 01:58:05 UTC)
#10
Hi Even, I'd like to change extension_api.json, but owner's lgtm is needed. Do you take ...
9 years, 3 months ago
(2011-08-30 10:40:37 UTC)
#12
Hi Even,
I'd like to change extension_api.json, but owner's lgtm is needed. Do you take a
look it?
Ben Olmstead
LGTM for extensions system changes. A few nits. http://codereview.chromium.org/7708025/diff/22001/chrome/browser/accessibility_events.h File chrome/browser/accessibility_events.h (right): http://codereview.chromium.org/7708025/diff/22001/chrome/browser/accessibility_events.h#newcode19 chrome/browser/accessibility_events.h:19: // ...
9 years, 3 months ago
(2011-08-30 18:12:18 UTC)
#13
Issue 7708025: Adds extension APIs of events on changing volume.
(Closed)
Created 9 years, 4 months ago by yoshiki
Modified 9 years, 3 months ago
Reviewers: Evan Stade, Ben Olmstead
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 50