Issue 7708004: Fix ARM build for gcc-4.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7708004: Fix ARM build for gcc-4.6

Created:
9 years, 4 months ago by Peter Varga

Modified:
9 years, 4 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix ARM build for gcc-4.6 Remove unused variables. Patch by Peter Varga.

Patch Set 2 : Remove unnecessary Smi tags #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -15 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/arm/lithium-gap-resolver-arm.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

http://codereview.chromium.org/7708004/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7708004/diff/1/src/arm/code-stubs-arm.cc#newcode566 src/arm/code-stubs-arm.cc:566: __ rsb(dst1, dst1, Operand(Smi::FromInt(31))); This is wrong. Smi tagging ...

9 years, 4 months ago (2011-08-23 08:54:07 UTC) #2

Erik Corry

I made a new version of this change with most of your work in it: ...

9 years, 4 months ago (2011-08-23 09:40:28 UTC) #3

Erik Corry

9 years, 4 months ago (2011-08-23 09:41:15 UTC) #4

Sorry wrong URL, here is the correct one http://codereview.chromium.org/7706030/

Expand Messages | Collapse Messages

Issue 7708004: Fix ARM build for gcc-4.6

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary Smi tags #

Messages