Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 7706030: Fix ARM build for gcc-4.6. (Closed)

Created:
9 years, 4 months ago by Erik Corry
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix ARM build for gcc-4.6. This is based on Peter Varga's work in http://codereview.chromium.org/7708004/ but with a different solution for the Operand(0) int/pointer ambiguity. Committed: http://code.google.com/p/v8/source/detail?r=8998

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 17 chunks +15 lines, -17 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 4 months ago (2011-08-23 09:29:28 UTC) #1
Peter Varga
You should remove unused variables from the code-stubs-arm.cc too: src/arm/code-stubs-arm.cc:2427:12: error: variable 'scratch2' set but ...
9 years, 4 months ago (2011-08-23 09:49:38 UTC) #2
Erik Corry
Thanks Peter, I updated the change.
9 years, 4 months ago (2011-08-23 10:07:07 UTC) #3
William Hesse
9 years, 4 months ago (2011-08-23 11:51:17 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698