Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: chrome/browser/ui/panels/panel_manager.h

Issue 7706027: Addition testing for panels drag and drop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More code review feedback. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_manager.h
diff --git a/chrome/browser/ui/panels/panel_manager.h b/chrome/browser/ui/panels/panel_manager.h
index 1ece64e120af31f8cac463b18e707199e876d5f6..beb08a228c068e47980d8b28a7a3492010868f79 100644
--- a/chrome/browser/ui/panels/panel_manager.h
+++ b/chrome/browser/ui/panels/panel_manager.h
@@ -55,6 +55,11 @@ class PanelManager {
PanelManager();
+#if UNIT_TEST
+ const Panels& panels() { return panels_; }
jianli 2011/08/25 17:22:26 Please append const modifier.
prasadt 2011/08/25 18:10:30 Done.
+ static int horizontal_spacing() { return kPanelsHorizontalSpacing; }
+#endif
+
// Applies the new work area. This is called by OnDisplayChanged and the test
// code.
void SetWorkArea(const gfx::Rect& work_area);
@@ -84,6 +89,8 @@ class PanelManager {
void DragLeft();
void DragRight();
+ // Horizontal spacing between panels. Used for unit testing.
jianli 2011/08/25 17:22:26 Please remove this comment.
prasadt 2011/08/25 18:10:30 Done.
+
Panels panels_;
// Stores the panels that are pending to remove. We want to delay the removal
@@ -112,6 +119,9 @@ class PanelManager {
// to when the dragging ends.
gfx::Rect dragging_panel_bounds_;
+ // Horizontal spacing between two panels.
+ static const int kPanelsHorizontalSpacing = 4;
+
DISALLOW_COPY_AND_ASSIGN(PanelManager);
};

Powered by Google App Engine
This is Rietveld 408576698