Addition testing for panels drag and drop.

chrome/browser/ui/panels/panel_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #pragma once
 
 #include <vector>
 #include "base/basictypes.h"
@@ skipping 66 matching lines @@
   bool ComputeBoundsForNextPanel(gfx::Rect* bounds, bool allow_size_change);
 
   // Finds one panel to close so that we may have space for the new panel
   // created by |extension|.
   void FindAndClosePanelOnOverflow(const Extension* extension);
 
   // Help functions to drag the given panel.
   void DragLeft();
   void DragRight();
 
+  // Horizontal spacing between panels.  Used for unit testing.
+  static int horizontal_spacing();

[jianli, 2011/08/24 20:23:24]

Can you make it public and add UNIT_TEST guard for it? You can move the
definition of constant to this header file.

Also, do not make it static method. Use
PanelManager::GetInstance()->horizontal_spacing() to access it in the calling
code, for consistency reason.

[prasadt, 2011/08/24 21:29:17]

I'd rather not do this change.  If we move one definition, we have to move
others too to keep it consistent but no one else needs them, so they really
belong in the cc file.

Also it makes more sense for this function to be a static because its just
returning a constant.

[jianli, 2011/08/24 22:04:02]

We're trying to avoid accessing private methods and members directly from the
testing code.

+
   Panels panels_;
 
   // Stores the panels that are pending to remove. We want to delay the removal
   // when we're in the process of the dragging.
   Panels panels_pending_to_remove_;
 
   // Current work area used in computing the panel bounds.
   gfx::Rect work_area_;
 
   // Used in computing the bounds of the next panel.
@@ skipping 12 matching lines @@
 
   // Bounds of the panel to drag. It is first set to the original bounds when
   // the dragging happens. Then it is updated to the position that will be set
   // to when the dragging ends.
   gfx::Rect dragging_panel_bounds_;
 
   DISALLOW_COPY_AND_ASSIGN(PanelManager);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_