Addition testing for panels drag and drop.

chrome/browser/ui/panels/panel_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 10 matching lines @@
 
 // Default width and height of a panel.
 const int kPanelDefaultWidthPixels = 240;
 const int kPanelDefaultHeightPixels = 290;
 
 // Maxmium width and height of a panel based on the factor of the working
 // area.
 const double kPanelMaxWidthFactor = 1.0;
 const double kPanelMaxHeightFactor = 0.5;
 
-// Horizontal spacing between two panels.
-const int kPanelsHorizontalSpacing = 4;
-
 // Single instance of PanelManager.
 scoped_ptr<PanelManager> panel_instance;
 }  // namespace
 
 // static
 PanelManager* PanelManager::GetInstance() {
   if (!panel_instance.get()) {
     panel_instance.reset(new PanelManager());
   }
   return panel_instance.get();
@@ skipping 300 matching lines @@
   current_x_ -= width + kPanelsHorizontalSpacing;
 
   bounds->SetRect(x, y, width, height);
   return true;
 }
 
 void PanelManager::RemoveAll() {
   // This should not be called when we're in the process of dragging.
   DCHECK(dragging_panel_index_ == kInvalidPanelIndex);
 
+  // Make a copy of the iterator as closing panels can modify the vector.
+  Panels panels_copy = panels_;
+
   // Start from the bottom to avoid reshuffling.
-  for (Panels::reverse_iterator iter = panels_.rbegin();
-       iter != panels_.rend(); ++iter)
+  for (Panels::reverse_iterator iter = panels_copy.rbegin();
+       iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool PanelManager::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }