Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/test/mini_installer_test/mini_installer_test_util.cc

Issue 7706026: Remove obselete --verbose-logging flag when launching installer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/mini_installer_test/mini_installer_test_util.cc
diff --git a/chrome/test/mini_installer_test/mini_installer_test_util.cc b/chrome/test/mini_installer_test/mini_installer_test_util.cc
index ec36231657111286c2109e45db273124a1cd54cc..16c8acd133d1fd2bf650216362b9c43516caa48e 100644
--- a/chrome/test/mini_installer_test/mini_installer_test_util.cc
+++ b/chrome/test/mini_installer_test/mini_installer_test_util.cc
@@ -79,13 +79,12 @@ bool MiniInstallerTestUtil::GetCommandForTagging(
return false;
}
- VLOG(1) << "Tagging command: " << standalone_installer_path.value().c_str();
*return_command = base::StringPrintf(L"%ls %ls %ls %ls",
mini_installer_constants::kChromeApplyTagExe,
standalone_installer_path.value().c_str(),
tagged_installer_path.c_str(),
mini_installer_constants::kChromeApplyTagParameters);
- VLOG(1) << "Command to run Apply tag: " << return_command;
+ VLOG(1) << "Command to run Apply tag: " << return_command->c_str();
kkania 2011/08/26 17:40:58 shouldn't need this, just log << *return_command
Huyen 2011/08/26 19:19:46 Done.
return true;
}
@@ -93,7 +92,6 @@ std::wstring MiniInstallerTestUtil::GetFilePath(const wchar_t* exe_name) {
FilePath installer_path;
PathService::Get(base::DIR_EXE, &installer_path);
installer_path = installer_path.Append(exe_name);
- VLOG(1) << "Chrome exe path: " << installer_path.value().c_str();
return installer_path.value();
}
@@ -259,7 +257,7 @@ bool MiniInstallerTestUtil::GetStandaloneVersion(
if (build.empty())
return false;
*version = build;
- VLOG(1) << "Standalone installer version: " << version;
+ VLOG(1) << "Standalone installer version: " << version->c_str();
kkania 2011/08/26 17:40:58 same here
Huyen 2011/08/26 19:19:46 Done.
return true;
}

Powered by Google App Engine
This is Rietveld 408576698