Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 7706026: Remove obselete --verbose-logging flag when launching installer. (Closed)

Created:
9 years, 4 months ago by Huyen
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove obselete --verbose-logging flag when launching installer. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98489

Patch Set 1 #

Total comments: 6

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Huyen
kkania, please take a look when you have time. thanks!
9 years, 4 months ago (2011-08-24 18:50:47 UTC) #1
kkania
LGTM after fixes http://codereview.chromium.org/7706026/diff/1/chrome/test/mini_installer_test/chrome_mini_installer.cc File chrome/test/mini_installer_test/chrome_mini_installer.cc (right): http://codereview.chromium.org/7706026/diff/1/chrome/test/mini_installer_test/chrome_mini_installer.cc#newcode596 chrome/test/mini_installer_test/chrome_mini_installer.cc:596: std::wstring launch_args(L""); drop the (L"") http://codereview.chromium.org/7706026/diff/1/chrome/test/mini_installer_test/mini_installer_test_util.cc ...
9 years, 4 months ago (2011-08-26 17:40:58 UTC) #2
Huyen
http://codereview.chromium.org/7706026/diff/1/chrome/test/mini_installer_test/chrome_mini_installer.cc File chrome/test/mini_installer_test/chrome_mini_installer.cc (right): http://codereview.chromium.org/7706026/diff/1/chrome/test/mini_installer_test/chrome_mini_installer.cc#newcode596 chrome/test/mini_installer_test/chrome_mini_installer.cc:596: std::wstring launch_args(L""); On 2011/08/26 17:40:58, kkania wrote: > drop ...
9 years, 4 months ago (2011-08-26 19:19:46 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-26 21:18:54 UTC) #4
Change committed as 98489

Powered by Google App Engine
This is Rietveld 408576698