webkit/plugins/ppapi/ppapi_plugin_instance.cc - Issue 7706021: Convert FileRefImpl and URLRequestInfo to shared_impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 7706021: Convert FileRefImpl and URLRequestInfo to shared_impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tests fixed Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc

diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

index 9fb77e071a29342504dea911cd00751dd35488a8..c353ed898e3da5c649f2c935a4fb6975f8a7ff88 100644

--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc

+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

@@ -1000,7 +1000,10 @@ int32_t PluginInstance::Navigate(PPB_URLRequestInfo_Impl* request,

WebFrame* frame = document.frame();

if (!frame)

return PP_ERROR_FAILED;

- WebURLRequest web_request(request->ToWebURLRequest(frame));

+ WebURLRequest web_request;

+ if (!request->ToWebURLRequest(frame, &web_request))

+ return PP_ERROR_FAILED;

web_request.setFirstPartyForCookies(document.firstPartyForCookies());

web_request.setHasUserGesture(from_user_action);