Use precompiled headers for most large projects.

webkit/plugins/ppapi/url_request_info_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/thunk/thunk.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebURLRequest.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
@@ skipping 84 matching lines @@
   static TestWebFrameClient web_frame_client_;
   static WebView* web_view_;
   static WebFrame* frame_;
 };
 
 TestWebFrameClient URLRequestInfoTest::web_frame_client_;
 WebView* URLRequestInfoTest::web_view_;
 WebFrame* URLRequestInfoTest::frame_;
 
 TEST_F(URLRequestInfoTest, GetInterface) {
-  const PPB_URLRequestInfo* interface =
+  const PPB_URLRequestInfo* iface =

[jeanluc1, 2011/08/22 22:20:24]

We're supposed to avoid abbeviation and 'iface' is cryptic.  I would suggest
'request_info'.

[Jói, 2011/08/24 13:56:33]

Done.

       ::ppapi::thunk::GetPPB_URLRequestInfo_Thunk();
-  ASSERT_TRUE(interface);
-  ASSERT_TRUE(interface->Create);
-  ASSERT_TRUE(interface->IsURLRequestInfo);
-  ASSERT_TRUE(interface->SetProperty);
-  ASSERT_TRUE(interface->AppendDataToBody);
-  ASSERT_TRUE(interface->AppendFileToBody);
-  ASSERT_TRUE(interface->Create);
-  ASSERT_TRUE(interface->Create);
+  ASSERT_TRUE(iface);
+  ASSERT_TRUE(iface->Create);
+  ASSERT_TRUE(iface->IsURLRequestInfo);
+  ASSERT_TRUE(iface->SetProperty);
+  ASSERT_TRUE(iface->AppendDataToBody);
+  ASSERT_TRUE(iface->AppendFileToBody);
+  ASSERT_TRUE(iface->Create);
+  ASSERT_TRUE(iface->Create);
 }
 
 TEST_F(URLRequestInfoTest, AsURLRequestInfo) {
   ASSERT_EQ(info_, info_->AsPPB_URLRequestInfo_API());
 }
 
 TEST_F(URLRequestInfoTest, StreamToFile) {
   info_->SetStringProperty(PP_URLREQUESTPROPERTY_URL, "http://www.google.com");
 
   ASSERT_FALSE(GetDownloadToFile());
@@ skipping 154 matching lines @@
   ASSERT_FALSE(info_->SetStringProperty(
       PP_URLREQUESTPROPERTY_HEADERS, "foo: bar\ncookie: foo"));
   ASSERT_TRUE(IsNullOrEmpty(GetHeaderValue("cookie")));
 }
 
 // TODO(bbudge) Unit tests for AppendDataToBody, AppendFileToBody.
 
 }  // namespace ppapi
 }  // namespace webkit