Use precompiled headers for most large projects.

ppapi/proxy/ppapi_proxy_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppapi_proxy_test.h"
 
 #include "base/message_loop_proxy.h"
 #include "base/observer_list.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 45 matching lines @@
 // GetInterface handlers (for TwoWayTest).  In the latter case, one handler is
 // for the PluginProxyTestHarness and should only respond for PPP interfaces,
 // and the other handler is for the HostProxyTestHarness which should only
 // ever respond for PPB interfaces.
 ObserverList<ProxyTestHarnessBase> get_interface_handlers_;
 
 const void* MockGetInterface(const char* name) {
   ObserverList<ProxyTestHarnessBase>::Iterator it =
       get_interface_handlers_;
   while (ProxyTestHarnessBase* observer = it.GetNext()) {
-    const void* interface = observer->GetInterface(name);
-    if (interface)
-      return interface;
+    const void* iface = observer->GetInterface(name);

[jeanluc1, 2011/08/22 22:20:24]

I find the abbreviation 'iface' cryptic.  I would suggest
'mock_interface'.

[Jói, 2011/08/24 13:56:33]

Done.

+    if (iface)
+      return iface;
   }
   if (strcmp(name, PPB_PROXY_PRIVATE_INTERFACE) == 0)
     return &ppb_proxy_private;
   return NULL;
 }
 
 void SetUpRemoteHarness(ProxyTestHarnessBase* harness,
                         const IPC::ChannelHandle& handle,
                         base::MessageLoopProxy* ipc_message_loop_proxy,
                         base::WaitableEvent* shutdown_event,
@@ skipping 20 matching lines @@
 
 ProxyTestHarnessBase::~ProxyTestHarnessBase() {
   get_interface_handlers_.RemoveObserver(this);
 }
 
 const void* ProxyTestHarnessBase::GetInterface(const char* name) {
   return registered_interfaces_[name];
 }
 
 void ProxyTestHarnessBase::RegisterTestInterface(const char* name,
-                                                 const void* interface) {
-  registered_interfaces_[name] = interface;
+                                                 const void* iface) {

[jeanluc1, 2011/08/22 22:20:24]

I find the abbreviation 'iface' cryptic.  I would suggest
'test_interface'.

You may want to check 'iface' in header files too.

[Jói, 2011/08/24 13:56:33]

Done, changed header file too.

+  registered_interfaces_[name] = iface;
 }
 
 bool ProxyTestHarnessBase::SupportsInterface(const char* name) {
   sink().ClearMessages();
 
   // IPC doesn't actually write to this when we send a message manually
   // not actually using IPC.
   bool unused_result = false;
   PpapiMsg_SupportsInterface msg(name, &unused_result);
   GetDispatcher()->OnMessageReceived(msg);
@@ skipping 245 matching lines @@
   remote_harness_torn_down.Wait();
 
   local_harness_->TearDownHarness();
 
   io_thread_.Stop();
 }
 
 
 }  // namespace proxy
 }  // namespace pp