Fixes regression (and crash) in instant. The crash would happen if

Fixes regression (and crash) in instant. The crash would happen if
instant is enabled, you go to a page with an auth dialog, then click
on one of the login buttons. This previously worked because focus was
going to either the widget for the TabContentsView or RWHV (not sure
which). Now that focus always goes to the topmost widget, it broke.

BUG=89439
TEST=none
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97734

[Ben Goodger (Google), 2011-08-22 15:57:16]

You said "Now that focus always goes to the topmost widget." Can you elaborate?
When did this change?

[sky, 2011-08-22 16:11:29]

On Mon, Aug 22, 2011 at 8:57 AM,  <ben@chromium.org> wrote:
> You said "Now that focus always goes to the topmost widget." Can you
> elaborate?
> When did this change?

Certainly. When you click the button in the auth dialog
View::RequestFocus asks the FocusManager of the top level widget (the
browser in this case) to focus itself. I'm pretty sure that a while
back focus remained (or at least initially) went to a child of the
TabContentsView.

  -Scott

[Ben Goodger (Google), 2011-08-22 16:13:13]

Are you saying that if you called ::GetFocus() the resulting HWND would be
the browser one - not the one you just moused down on? So none of the child
HWNDs in the browser window are focusable? Do you know how we achieve this?

-Ben

On Mon, Aug 22, 2011 at 9:11 AM, Scott Violet <sky@chromium.org> wrote:

> On Mon, Aug 22, 2011 at 8:57 AM,  <ben@chromium.org> wrote:
> > You said "Now that focus always goes to the topmost widget." Can you
> > elaborate?
> > When did this change?
>
> Certainly. When you click the button in the auth dialog
> View::RequestFocus asks the FocusManager of the top level widget (the
> browser in this case) to focus itself. I'm pretty sure that a while
> back focus remained (or at least initially) went to a child of the
> TabContentsView.
>
>  -Scott
>

[Ben Goodger (Google), 2011-08-22 16:20:35]

LGTM then... not generally happy having to wire up stuff like this but I think
this is the fault of the current focus behavior. Eventually someone will look at
it :-)