Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 7706002: Slight API change enabling opting out from null termination in String::Write*(). (Closed)

Created:
9 years, 4 months ago by Yang
Modified:
9 years, 4 months ago
Reviewers:
antonm, Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Slight API change enabling opting out from null termination in String::Write*(). BUG=v8:1537 TEST=cctest test-api/StringWrite Committed: http://code.google.com/p/v8/source/detail?r=8996

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M include/v8.h View 1 chunk +8 lines, -7 lines 4 comments Download
M src/api.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
At the request of v8 users who want to be able to opt out from ...
9 years, 4 months ago (2011-08-22 14:30:25 UTC) #1
Vitaly Repeshko
9 years, 4 months ago (2011-08-23 10:55:40 UTC) #2
LGTM

http://codereview.chromium.org/7706002/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/7706002/diff/1/include/v8.h#newcode1042
include/v8.h:1042: * \param options Various hints that might affect performance
of this or
Various options?

http://codereview.chromium.org/7706002/diff/1/include/v8.h#newcode1048
include/v8.h:1048: enum WriteHints {
WriteOptions?

http://codereview.chromium.org/7706002/diff/1/include/v8.h#newcode1050
include/v8.h:1050: MANY_WRITES_EXPECTED = 1,
Keep HINT_?

http://codereview.chromium.org/7706002/diff/1/include/v8.h#newcode1051
include/v8.h:1051: WRITE_NO_NULL_TERMINATION = 2
Drop WRITE_?

Powered by Google App Engine
This is Rietveld 408576698