Issue 7703007: Make instruction for write barrier smaller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7703007: Make instruction for write barrier smaller. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make instruction for write barrier smaller. R=yangguo@chromium.org BUG=v8:1495 Committed: http://code.google.com/p/v8/source/detail?r=8978

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

This fixes IA32 only. For X64 we already use the smaller version. For ARM we ...

9 years, 4 months ago (2011-08-22 09:03:41 UTC) #1

Yang

9 years, 4 months ago (2011-08-22 09:08:53 UTC) #2

LGTM.

On 2011/08/22 09:03:41, Michael Starzinger wrote:
> This fixes IA32 only. For X64 we already use the smaller version. For ARM we
> either use the ARMv7 "ubfx" instruction or a two-instruction supplement, in
both
> cases the mask fits into the immediate.

Expand Messages | Collapse Messages