Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7703005: Prune some internal objects' prototypes. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 4 months ago
Reviewers:
Rico
CC:
v8-dev, Mads Ager (chromium)
Visibility:
Public.

Description

Prune some internal objects' prototypes. Committed: http://code.google.com/p/v8/source/detail?r=8979

Patch Set 1 #

Patch Set 2 : Reuse original PropertyDescriptor approach. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M src/messages.js View 1 13 chunks +34 lines, -16 lines 0 comments Download
M src/string.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 4 months ago (2011-08-22 08:52:49 UTC) #1
Rico
9 years, 4 months ago (2011-08-22 09:01:26 UTC) #2
LGTM, consider using void 0 instead of null to be more consistent with remaining
code (yes, I know, no difference functionality wise here)

Powered by Google App Engine
This is Rietveld 408576698