Reuse existing object proxies and exported objects, if these exist.

Reuse existing object proxies and exported objects, if these exist.

The Bus object shouldn't return new objects if the bus object already owns
the requested object proxies, or the exported objects.

BUG=90036
TEST=dbus_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97898

[satorux1, 2011-08-19 22:28:42]

Sorry for keeping sending patches. Hopefully, it's almost there.

[stevenjb, 2011-08-22 17:46:21]

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h
File dbus/bus.h (right):

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode172
dbus/bus.h:172: // object proxy for the given the service name and the object
path.
s/the given the/the given/

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode193
dbus/bus.h:193: // the exported object for the given the service name and the
object path.
s/the given the/the given/

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode436
dbus/bus.h:436: // bus object. Key is a pair of service name and object path.
nit: Does it make sense to concatnate service name + object path for the key
here to avoid the complexity of a pair as a key?

[satorux1, 2011-08-22 19:01:58]

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h
File dbus/bus.h (right):

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode172
dbus/bus.h:172: // object proxy for the given the service name and the object
path.
On 2011/08/22 17:46:22, Steven Bennetts wrote:
> s/the given the/the given/

Done.

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode193
dbus/bus.h:193: // the exported object for the given the service name and the
object path.
On 2011/08/22 17:46:22, Steven Bennetts wrote:
> s/the given the/the given/

Done.

http://codereview.chromium.org/7702001/diff/1/dbus/bus.h#newcode436
dbus/bus.h:436: // bus object. Key is a pair of service name and object path.
On 2011/08/22 17:46:22, Steven Bennetts wrote:
> nit: Does it make sense to concatnate service name + object path for the key
> here to avoid the complexity of a pair as a key?

Good point. I thought about it but didn't go with it for some reason. Now I
think concatenating them makes sense, as it wouldn't cause ambiguity. It would
look like:

org.chromium.TestService/org/chromium/TestObject

Changed the code accordingly.

[stevenjb, 2011-08-22 23:27:45]

LGTM