base/shared_memory_android.cc - Issue 7701014: Upstream misc changes for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/shared_memory_android.cc

Issue 7701014: Upstream misc changes for android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added more files, and addressed the comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/shared_memory_android.cc

diff --git a/base/shared_memory_android.cc b/base/shared_memory_android.cc

index c2f33159f0730ec41f41808062b0ece50a4d7fc9..72c3a5684455e31cf8e309f28ab4b205bfdf31ef 100644

--- a/base/shared_memory_android.cc

+++ b/base/shared_memory_android.cc

@@ -39,9 +39,9 @@ bool SharedMemory::CreateNamed(const std::string& name,

}

bool SharedMemory::Delete(const std::string& name) {

- // ashmem doesn't support name mapping

- NOTIMPLEMENTED();

- return false;

+ // Like on Windows, this is intentionally returning true as ashmem will

+ // automatically releases the resource when all FDs on it are closed.

+ return true;

}

bool SharedMemory::Open(const std::string& name, bool read_only) {